Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 559403002: Expect access check in JSObject::DefineAccessor. (Closed)

Created:
6 years, 3 months ago by Yang
Modified:
6 years, 3 months ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Expect access check in JSObject::DefineAccessor. R=ulan@chromium.org, verwaest@chromium.org BUG=chromium:411793 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=23874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/objects.cc View 1 chunk +4 lines, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 3 months ago (2014-09-11 10:09:22 UTC) #1
ulan
lgtm
6 years, 3 months ago (2014-09-11 10:45:07 UTC) #2
Yang
6 years, 3 months ago (2014-09-11 12:16:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23874 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698