Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 559373004: Resize app list items in experimental app list. (Closed)

Created:
6 years, 3 months ago by calamity
Modified:
6 years, 3 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@dragging_without_grid_resize
Project:
chromium
Visibility:
Public.

Description

Change layout of app list items in experimental app list. This CL changes the experimental app list's AppListItem size when displayed in the AppsGridView and adds padding between each AppListItem. BUG=411775 Committed: https://crrev.com/1d06f53781f200e4339cb9c2495ec51fc304b5c9 Cr-Commit-Position: refs/heads/master@{#295228}

Patch Set 1 : #

Total comments: 6

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -14 lines) Patch
M ui/app_list/views/apps_grid_view.cc View 1 9 chunks +45 lines, -14 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
calamity
6 years, 3 months ago (2014-09-16 05:37:27 UTC) #3
Matt Giuca
lgtm https://codereview.chromium.org/559373004/diff/20001/ui/app_list/views/apps_grid_view.cc File ui/app_list/views/apps_grid_view.cc (right): https://codereview.chromium.org/559373004/diff/20001/ui/app_list/views/apps_grid_view.cc#newcode74 ui/app_list/views/apps_grid_view.cc:74: const int kExperimentalTileWidth = 90; Can this be ...
6 years, 3 months ago (2014-09-16 07:37:57 UTC) #4
calamity
https://codereview.chromium.org/559373004/diff/20001/ui/app_list/views/apps_grid_view.cc File ui/app_list/views/apps_grid_view.cc (right): https://codereview.chromium.org/559373004/diff/20001/ui/app_list/views/apps_grid_view.cc#newcode74 ui/app_list/views/apps_grid_view.cc:74: const int kExperimentalTileWidth = 90; On 2014/09/16 07:37:57, Matt ...
6 years, 3 months ago (2014-09-17 01:48:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559373004/40001
6 years, 3 months ago (2014-09-17 01:50:12 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-17 03:51:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559373004/40001
6 years, 3 months ago (2014-09-17 04:05:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:40001) as 2c41b2f36ea6a064f85371e60720a673279bc299
6 years, 3 months ago (2014-09-17 04:33:51 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 04:34:21 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1d06f53781f200e4339cb9c2495ec51fc304b5c9
Cr-Commit-Position: refs/heads/master@{#295228}

Powered by Google App Engine
This is Rietveld 408576698