Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: Source/bindings/core/v8/WorkerScriptController.cpp

Issue 559363002: Switch blink to use a gin-managed isolate. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: updates Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/V8PerIsolateData.cpp ('k') | Source/web/WebKit.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/WorkerScriptController.cpp
diff --git a/Source/bindings/core/v8/WorkerScriptController.cpp b/Source/bindings/core/v8/WorkerScriptController.cpp
index 843c316784c73a420497a9892547af1836e78cbe..8ebafdfe1fcc773312a944b369fbc9062c7cc352 100644
--- a/Source/bindings/core/v8/WorkerScriptController.cpp
+++ b/Source/bindings/core/v8/WorkerScriptController.cpp
@@ -105,16 +105,14 @@ public:
};
WorkerScriptController::WorkerScriptController(WorkerGlobalScope& workerGlobalScope)
- : m_isolate(v8::Isolate::New())
+ : m_isolate(0)
, m_workerGlobalScope(workerGlobalScope)
, m_executionForbidden(false)
, m_executionScheduledToTerminate(false)
, m_globalScopeExecutionState(0)
{
- m_isolate->Enter();
+ m_isolate = V8PerIsolateData::initialize();
V8Initializer::initializeWorker(m_isolate);
- v8::V8::Initialize();
- V8PerIsolateData::ensureInitialized(m_isolate);
m_world = DOMWrapperWorld::create(WorkerWorldId);
m_interruptor = adoptPtr(new V8IsolateInterruptor(m_isolate));
ThreadState::current()->addInterruptor(m_interruptor.get());
@@ -133,8 +131,6 @@ public:
virtual void postCleanup()
{
V8PerIsolateData::dispose(m_isolate);
- m_isolate->Exit();
- m_isolate->Dispose();
}
private:
« no previous file with comments | « Source/bindings/core/v8/V8PerIsolateData.cpp ('k') | Source/web/WebKit.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698