Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 559343002: Add AX attribute conversion for input type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add AX attribute conversion for input type Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_cocoa.mm
diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm
index a4b31fc227b19ee2e5d79a32dc0bab41b6942e3d..5f3143391953545c5a7f287e69cc6046a6b04db8 100644
--- a/content/browser/accessibility/browser_accessibility_cocoa.mm
+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm
@@ -112,6 +112,7 @@ NSDictionary* attributeToMethodNameMap = nil;
{ @"AXLoadingProgress", @"loadingProgress" },
{ @"AXRequired", @"required" },
{ @"AXVisited", @"visited" },
+ { @"AXTextInputType", @"textInputType" },
dmazzoni 2014/09/26 15:29:16 I can't find AXTextInputType documented anywhere.
je_julie(Not used) 2014/09/28 14:57:25 OK. I'll not add textinput type for mac for now.
};
NSMutableDictionary* dict = [[NSMutableDictionary alloc] init];
@@ -884,6 +885,11 @@ NSDictionary* attributeToMethodNameMap = nil;
GetState(browserAccessibility_, ui::AX_STATE_VISITED)];
}
+- (NSString*)textInputType {
+ return NSStringForStringAttribute(
+ browserAccessibility_, ui::AX_ATTR_TEXT_INPUT_TYPE);
+}
+
- (id)window {
if (!browserAccessibility_)
return nil;
@@ -1219,8 +1225,16 @@ NSDictionary* attributeToMethodNameMap = nil;
@"AXLoaded",
@"AXLoadingProgress",
nil]];
- } else if ([role isEqualToString:NSAccessibilityTextFieldRole] ||
- [role isEqualToString:NSAccessibilityTextAreaRole]) {
+ } else if ([role isEqualToString:NSAccessibilityTextFieldRole]) {
+ [ret addObjectsFromArray:[NSArray arrayWithObjects:
+ NSAccessibilityInsertionPointLineNumberAttribute,
+ NSAccessibilityNumberOfCharactersAttribute,
+ NSAccessibilitySelectedTextAttribute,
+ NSAccessibilitySelectedTextRangeAttribute,
+ NSAccessibilityVisibleCharacterRangeAttribute,
+ @"AXTextInputType",
+ nil]];
+ } else if ([role isEqualToString:NSAccessibilityTextAreaRole]) {
[ret addObjectsFromArray:[NSArray arrayWithObjects:
NSAccessibilityInsertionPointLineNumberAttribute,
NSAccessibilityNumberOfCharactersAttribute,

Powered by Google App Engine
This is Rietveld 408576698