Add AX attribute conversion for input type

Add AX attribute conversion for input type

Exposed input type for tel, search, url and email on mac and windows.
The Related CL:
https://codereview.chromium.org/596393004/

BUG=323161
Committed: https://crrev.com/91d4e092d3a07e46ad55062dc0883071b3fe47e4
Cr-Commit-Position: refs/heads/master@{#298008}

[je_julie(Not used), 2014-09-26 14:31:13]

je_julie.kim@samsung.com changed reviewers:
+ aboxhall@chromium.org, dmazzoni@chromium.org, dtseng@chromium.org

[je_julie(Not used), 2014-09-26 14:31:56]

Dominic, David, aboxhall,
PTAL.

[dmazzoni, 2014-09-26 15:29:16]

https://codereview.chromium.org/559343002/diff/20001/content/browser/accessib...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

https://codereview.chromium.org/559343002/diff/20001/content/browser/accessib...
content/browser/accessibility/browser_accessibility_cocoa.mm:115: {
@"AXTextInputType", @"textInputType" },
I can't find AXTextInputType documented anywhere.

All of the "AX..." attributes are either documented as part of the
NSAccessibility protocol (by Apple), or undocumented attributes found in WebKit
source code.

https://codereview.chromium.org/559343002/diff/20001/content/browser/accessib...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/559343002/diff/20001/content/browser/accessib...
content/browser/accessibility/browser_accessibility_win.cc:2912:
StringAttributeToIA2(ui::AX_ATTR_TEXT_INPUT_TYPE, "text_input_type");
This must be exactly "text-input-type" to match Mozilla.

https://bugzilla.mozilla.org/attachment.cgi?id=821260&action=edit

https://codereview.chromium.org/559343002/diff/20001/content/renderer/accessi...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/559343002/diff/20001/content/renderer/accessi...
content/renderer/accessibility/blink_ax_tree_source.cc:351:
UTF16ToUTF8(src.textInputType()));
nit: either line up with ui::AX_ATTR_... from previous line, or indent exactly 4
spaces.

https://codereview.chromium.org/559343002/diff/20001/content/test/data/access...
File content/test/data/accessibility/input-types-expected-win.txt (right):

https://codereview.chromium.org/559343002/diff/20001/content/test/data/access...
content/test/data/accessibility/input-types-expected-win.txt:1:
ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
This file should show the text-input-type attribute, otherwise what are we
testing?

Try temporarily adding @WIN-ALLOW:* to make sure it's being dumped, then tighten
it to only dump that attribute.

https://codereview.chromium.org/559343002/diff/20001/ui/accessibility/ax_enum...
File ui/accessibility/ax_enums.idl (right):

https://codereview.chromium.org/559343002/diff/20001/ui/accessibility/ax_enum...
ui/accessibility/ax_enums.idl:241: text_input_type
No need to separate this one, just sort it with the others

[je_julie(Not used), 2014-09-28 14:57:26]

Thanks for review.
I'll update patch with your feedback.

https://codereview.chromium.org/559343002/diff/20001/content/browser/accessib...
File content/browser/accessibility/browser_accessibility_cocoa.mm (right):

https://codereview.chromium.org/559343002/diff/20001/content/browser/accessib...
content/browser/accessibility/browser_accessibility_cocoa.mm:115: {
@"AXTextInputType", @"textInputType" },
OK. I'll not add textinput type for mac for now.

On 2014/09/26 15:29:16, dmazzoni wrote:
> I can't find AXTextInputType documented anywhere.
> 
> All of the "AX..." attributes are either documented as part of the
> NSAccessibility protocol (by Apple), or undocumented attributes found in
WebKit
> source code.

https://codereview.chromium.org/559343002/diff/20001/content/browser/accessib...
File content/browser/accessibility/browser_accessibility_win.cc (right):

https://codereview.chromium.org/559343002/diff/20001/content/browser/accessib...
content/browser/accessibility/browser_accessibility_win.cc:2912:
StringAttributeToIA2(ui::AX_ATTR_TEXT_INPUT_TYPE, "text_input_type");
I'll update it.
On 2014/09/26 15:29:16, dmazzoni wrote:
> This must be exactly "text-input-type" to match Mozilla.
> 
> https://bugzilla.mozilla.org/attachment.cgi?id=821260&action=edit

https://codereview.chromium.org/559343002/diff/20001/content/renderer/accessi...
File content/renderer/accessibility/blink_ax_tree_source.cc (right):

https://codereview.chromium.org/559343002/diff/20001/content/renderer/accessi...
content/renderer/accessibility/blink_ax_tree_source.cc:351:
UTF16ToUTF8(src.textInputType()));
OK. I'll line up.
On 2014/09/26 15:29:16, dmazzoni wrote:
> nit: either line up with ui::AX_ATTR_... from previous line, or indent exactly
4
> spaces.

https://codereview.chromium.org/559343002/diff/20001/content/test/data/access...
File content/test/data/accessibility/input-types-expected-win.txt (right):

https://codereview.chromium.org/559343002/diff/20001/content/test/data/access...
content/test/data/accessibility/input-types-expected-win.txt:1:
ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
Thank you for information.
On 2014/09/26 15:29:16, dmazzoni wrote:
> This file should show the text-input-type attribute, otherwise what are we
> testing?
> 
> Try temporarily adding @WIN-ALLOW:* to make sure it's being dumped, then
tighten
> it to only dump that attribute.
>

https://codereview.chromium.org/559343002/diff/20001/ui/accessibility/ax_enum...
File ui/accessibility/ax_enums.idl (right):

https://codereview.chromium.org/559343002/diff/20001/ui/accessibility/ax_enum...
ui/accessibility/ax_enums.idl:241: text_input_type
I'll update it.
On 2014/09/26 15:29:16, dmazzoni wrote:
> No need to separate this one, just sort it with the others

[dmazzoni, 2014-09-29 05:35:01]

lgtm

[je_julie(Not used), 2014-10-01 15:58:07]

Hi Dominic,

I updated TC and results from it.
This patch got affected from https://codereview.chromium.org/615773002/ because
it added new rules for input type for date types.
It seems that implementation for chromium side is on-going.

1) I removed some input tags for data types to avoid conflict. I'll add that
tags after I checked date type implementation is completed.
2) I added new test results according to changes from blink side,
https://codereview.chromium.org/596393004/.
Blink will export TextField input types such as tel, email, password, text,
search, url.
PTAL.

[dmazzoni, 2014-10-01 19:43:27]

The CQ bit was checked by dmazzoni@chromium.org

[dmazzoni, 2014-10-01 19:43:27]

lgtm

[commit-bot: I haz the power, 2014-10-01 19:47:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/559343002/60001

[commit-bot: I haz the power, 2014-10-01 20:01:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-01 20:01:34]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[je_julie(Not used), 2014-10-02 00:17:27]

On 2014/10/01 20:01:34, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_gn_dbg on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   mac_chromium_compile_dbg on tryserver.chromium.mac
>
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

Let me commit the related patch in blink first and then I'll re-commit it after
blink and chromium are synced.

[je_julie(Not used), 2014-10-02 10:34:36]

The CQ bit was checked by je_julie.kim@samsung.com

[commit-bot: I haz the power, 2014-10-02 10:35:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/559343002/60001

[commit-bot: I haz the power, 2014-10-02 10:46:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-02 10:46:41]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[je_julie(Not used), 2014-10-03 06:05:26]

The CQ bit was checked by je_julie.kim@samsung.com

[commit-bot: I haz the power, 2014-10-03 06:05:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/559343002/60001

[commit-bot: I haz the power, 2014-10-03 07:14:12]

Committed patchset #4 (id:60001) as a3fc71b91dc20c2019ded08dfc4e49a691d8c787

[commit-bot: I haz the power, 2014-10-03 07:14:47]

Patchset 4 (id:??) landed as
https://crrev.com/91d4e092d3a07e46ad55062dc0883071b3fe47e4
Cr-Commit-Position: refs/heads/master@{#298008}