runtime/vm/intermediate_language_ia32.cc - Issue 559313004: VM: Remove unreachable code from the code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 559313004: VM: Remove unreachable code from the code generator. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

===================================================================

--- runtime/vm/intermediate_language_ia32.cc (revision 40376)

+++ runtime/vm/intermediate_language_ia32.cc (working copy)

@@ -5357,12 +5357,6 @@

void PolymorphicInstanceCallInstr::EmitNativeCode(FlowGraphCompiler* compiler) {

- Label* deopt = compiler->AddDeoptStub(

- deopt_id(), ICData::kDeoptPolymorphicInstanceCallTestFail);

- if (ic_data().NumberOfUsedChecks() == 0) {

- __ jmp(deopt);

- return;

- }

ASSERT(ic_data().NumArgsTested() == 1);

if (!with_checks()) {

ASSERT(ic_data().HasOneTarget());

@@ -5381,6 +5375,8 @@

__ movl(EAX,

Address(ESP, (instance_call()->ArgumentCount() - 1) * kWordSize));

+ Label* deopt = compiler->AddDeoptStub(

+ deopt_id(), ICData::kDeoptPolymorphicInstanceCallTestFail);

LoadValueCid(compiler, EDI, EAX,

(ic_data().GetReceiverClassIdAt(0) == kSmiCid) ? NULL : deopt);

« no previous file with comments | « runtime/vm/intermediate_language_arm64.cc ('k') | runtime/vm/intermediate_language_mips.cc » ('j') | no next file with comments »