Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6883)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 559303002: Hotword Audio Verification app: control the hotword settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@launch-state
Patch Set: Re-add lost code, small change to browser_options.js Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 77ecd442605bb8bd2b7f014dab0c31443d2373d2..bd4b9f31b3d8e837f38b57aed5bf46563041c035 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -212,6 +212,19 @@ cr.define('options', function() {
};
}
+ // Control the hotword-always-on pref with the Hotword Audio
+ // Verification app.
+ $('hotword-always-on-search-checkbox').customChangeHandler =
+ function(event) {
+ if (($('hotword-always-on-search-checkbox').checked)) {
Dan Beam 2014/09/23 05:53:38 remove extra parens
Dan Beam 2014/09/23 05:53:38 nit: if (!$('hotword-always-on-search-checkbox'
kcarattini 2014/09/23 06:46:16 Done.
kcarattini 2014/09/23 06:46:16 Done.
+ $('hotword-always-on-search-checkbox').checked = false;
+ chrome.send('launchHotwordAudioVerificationApp', [Boolean(false)]);
Dan Beam 2014/09/23 05:53:38 just false... no Boolean() required
kcarattini 2014/09/23 06:46:16 Done.
+ return true;
+ }
+
+ return false;
+ };
+
$('themes-gallery').onclick = function(event) {
window.open(loadTimeData.getString('themesGalleryURL'));
chrome.send('coreOptionsUserMetricsAction',

Powered by Google App Engine
This is Rietveld 408576698