Hotword Audio Verification app: control the hotword settings

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
@@ skipping 194 matching lines @@
       chrome.send('requestHotwordAvailable');
 
       if ($('set-wallpaper')) {
         $('set-wallpaper').onclick = function(event) {
           chrome.send('openWallpaperManager');
           chrome.send('coreOptionsUserMetricsAction',
                       ['Options_OpenWallpaperManager']);
         };
       }
 
+      // Control the hotword-always-on pref with the Hotword Audio
+      // Verification app.
+      $('hotword-always-on-search-checkbox').customChangeHandler =
+          function(event) {
+        if (($('hotword-always-on-search-checkbox').checked)) {

[Dan Beam, 2014/09/23 05:53:38]

remove extra parens

[Dan Beam, 2014/09/23 05:53:38]

nit:

  if (!$('hotword-always-on-search-checkbox').checked)
    return false;

  $('hotword-always-on-search-checkbox').checked = false;
  chrome.send('launchHotwordAudioVerificationApp', [false]);
  return true;

[kcarattini, 2014/09/23 06:46:16]

Done.

[kcarattini, 2014/09/23 06:46:16]

Done.

+          $('hotword-always-on-search-checkbox').checked = false;
+          chrome.send('launchHotwordAudioVerificationApp', [Boolean(false)]);

[Dan Beam, 2014/09/23 05:53:38]

just false... no Boolean() required

[kcarattini, 2014/09/23 06:46:16]

Done.

+          return true;
+        }
+
+        return false;
+      };
+
       $('themes-gallery').onclick = function(event) {
         window.open(loadTimeData.getString('themesGalleryURL'));
         chrome.send('coreOptionsUserMetricsAction',
                     ['Options_ThemesGallery']);
       };
       $('themes-reset').onclick = function(event) {
         chrome.send('themesReset');
       };
 
       if (loadTimeData.getBoolean('profileIsSupervised')) {
@@ skipping 1769 matching lines @@
       }
       button.textContent = loadTimeData.getString(strId);
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });