Hotword Audio Verification app: control the hotword settings

chrome/browser/extensions/api/hotword_private/hotword_private_api.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/hotword_private/hotword_private_api.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 75 matching lines @@
   PrefService* prefs = GetProfile()->GetPrefs();
   prefs->SetBoolean(prefs::kHotwordSearchEnabled, params->state);
   return true;
 }
 
 bool HotwordPrivateSetAudioLoggingEnabledFunction::RunSync() {
   scoped_ptr<api::hotword_private::SetEnabled::Params> params(
       api::hotword_private::SetEnabled::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
+  // TODO(kcarattini): Sync the chrome pref with the account-level
+  // Audio History setting.
+  PrefService* prefs = GetProfile()->GetPrefs();
+  prefs->SetBoolean(prefs::kHotwordAudioLoggingEnabled, params->state);
+  return true;
+}
+
+bool HotwordPrivateSetHotwordAlwaysOnSearchEnabledFunction::RunSync() {
+  scoped_ptr<api::hotword_private::SetEnabled::Params> params(

[rpetterson, 2014/09/11 20:14:17]

This should be:
scoped_ptr<api::hotword_private::SetHotwordAlwaysOnSearchEnabled::Params> params

And if you could also fix it in SetAudioLogging (which was my bad) that would be
super. :)

[kcarattini, 2014/09/12 01:02:07]

Done.

+      api::hotword_private::SetEnabled::Params::Create(*args_));
+  EXTENSION_FUNCTION_VALIDATE(params.get());
+
   PrefService* prefs = GetProfile()->GetPrefs();
-  prefs->SetBoolean(prefs::kHotwordAudioLoggingEnabled, params->state);
+  prefs->SetBoolean(prefs::kHotwordAlwaysOnSearchEnabled, params->state);
   return true;
 }
 
 bool HotwordPrivateGetStatusFunction::RunSync() {
   api::hotword_private::StatusDetails result;
 
   HotwordService* hotword_service =
       HotwordServiceFactory::GetForProfile(GetProfile());
   if (!hotword_service)
     result.available = false;
@@ skipping 45 matching lines @@
   } else {
     result.launch_mode =
         hotword_service->GetHotwordAudioVerificationLaunchMode();
   }
 
   SetResult(result.ToValue().release());
   return true;
 }
 
 }  // namespace extensions