Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Issue 559263002: Replaced Metafile with PdfMetafileSkia in renderer. (Closed)

Created:
6 years, 3 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replaced Metafile with PdfMetafileSkia in renderer. All platforms uses PdfMetafileSkia now. TBR=sgurun@chromium.org Committed: https://crrev.com/a68e23e16cdfddf52ba2aedd2c093c1854145b15 Cr-Commit-Position: refs/heads/master@{#294514}

Patch Set 1 #

Patch Set 2 : Wed Sep 10 19:16:27 PDT 2014 #

Patch Set 3 : Wed Sep 10 19:19:17 PDT 2014 #

Patch Set 4 : Thu Sep 11 15:19:07 PDT 2014 #

Patch Set 5 : Thu Sep 11 15:32:59 PDT 2014 #

Patch Set 6 : Thu Sep 11 15:35:21 PDT 2014 #

Patch Set 7 : Thu Sep 11 15:38:44 PDT 2014 #

Patch Set 8 : Thu Sep 11 15:46:31 PDT 2014 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -60 lines) Patch
M android_webview/renderer/print_web_view_helper.h View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M android_webview/renderer/print_web_view_helper.cc View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M android_webview/renderer/print_web_view_helper_linux.cc View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 2 3 4 5 6 7 2 chunks +10 lines, -12 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.h View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper.cc View 1 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_linux.cc View 1 3 chunks +3 lines, -4 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_mac.mm View 1 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_pdf_win.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M printing/metafile_skia_wrapper.h View 1 chunk +7 lines, -6 lines 0 comments Download
M printing/metafile_skia_wrapper.cc View 3 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Vitaly Buka (NO REVIEWS)
6 years, 3 months ago (2014-09-11 18:46:24 UTC) #3
yzshen1
LGTM for *pepper*
6 years, 3 months ago (2014-09-11 21:03:04 UTC) #4
Lei Zhang
lgtm
6 years, 3 months ago (2014-09-11 21:41:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559263002/80002
6 years, 3 months ago (2014-09-11 23:22:43 UTC) #10
commit-bot: I haz the power
Committed patchset #8 (id:80002) as e6c05ffba7caa2b59d17fb6f7003d041a5c43443
6 years, 3 months ago (2014-09-12 01:00:12 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 01:04:31 UTC) #12
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/a68e23e16cdfddf52ba2aedd2c093c1854145b15
Cr-Commit-Position: refs/heads/master@{#294514}

Powered by Google App Engine
This is Rietveld 408576698