Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 559233002: [NaCl SDK] Never check SVN or git-svn for Chromium repo. (Closed)

Created:
6 years, 3 months ago by binji
Modified:
6 years, 3 months ago
Reviewers:
bradnelson, bradn, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Never check SVN or git-svn for Chromium repo. This will need to be merged back to M38. No trybots because this only affects the NaCl SDK build. BUG=none R=bradnelson@chromium.org NOTRY=true Committed: https://crrev.com/7e8e1bc34c946f7f361bfd16c2628170b55dd45a Cr-Commit-Position: refs/heads/master@{#294253}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -21 lines) Patch
M native_client_sdk/src/build_tools/build_version.py View 2 chunks +2 lines, -21 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
binji
6 years, 3 months ago (2014-09-10 22:25:57 UTC) #1
bradn
lgtm
6 years, 3 months ago (2014-09-10 22:26:19 UTC) #3
Sam Clegg
lgtm
6 years, 3 months ago (2014-09-10 22:34:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559233002/1
6 years, 3 months ago (2014-09-10 22:51:19 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 23aaf8634140acae74a95c8b763acb1a781fb0df
6 years, 3 months ago (2014-09-10 23:17:42 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 23:21:48 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7e8e1bc34c946f7f361bfd16c2628170b55dd45a
Cr-Commit-Position: refs/heads/master@{#294253}

Powered by Google App Engine
This is Rietveld 408576698