Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Unified Diff: ash/display/display_manager.cc

Issue 559213002: Force calling PostDisplayConfigurationChange() even if earyling out in UpdateDisplays (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/display/display_manager.cc
diff --git a/ash/display/display_manager.cc b/ash/display/display_manager.cc
index 29eced4cc03ec6eee89c4e70a04ad674edb7a05b..c61b876e68f36e198acbcf4e40b3654ccf274db7 100644
--- a/ash/display/display_manager.cc
+++ b/ash/display/display_manager.cc
@@ -889,6 +889,14 @@ void DisplayManager::UpdateDisplays(
// http://crbug.com/155948.
if (display_changes.empty() && added_display_indices.empty() &&
removed_displays.empty()) {
+ // When changing from software mirroring mode to sinlge display mode, it
+ // is possible there is no need to update |displays_| and we early out
+ // here. But we still want to run the PostDisplayConfigurationChange()
+ // cause there are some clients need to act on this, e.g.
+ // TouchTransformerController needs to adjust the TouchTransformer when
+ // switching from dual displays to single display.
+ if (delegate_)
Yufeng Shen (Slow to review) 2014/09/11 16:24:02 hmmm, DisplayControllerTest catches this that we m
oshima 2014/09/11 17:19:08 Yes, it has to be paired. You can move the PreDisp
Yufeng Shen (Slow to review) 2014/09/11 18:25:49 Done.
+ delegate_->PostDisplayConfigurationChange();
return;
}
// Clear focus if the display has been removed, but don't clear focus if
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698