Force calling PostDisplayConfigurationChange() even if earyling out in UpdateDisplays

Force calling PostDisplayConfigurationChange() even if earyling out in UpdateDisplays

When changing from software mirroring mode to sinlge display mode, it
is possible there is no need to update |displays_| and we early out
UpdateDisplays(). But we still want to run the PostDisplayConfigurationChange()
cause there are some clients need to act on this, e.g.
TouchTransformerController needs to adjust the TouchTransformer when
switching from dual displays to single display.

BUG=chrome-os-partner:31868
TEST=tested on Big, after existing software mirroring mode, the touch location
     transformation is still correct.

Committed: https://crrev.com/4802a8552a40e1f80606ca7171dc2f79930e7fb3
Cr-Commit-Position: refs/heads/master@{#294481}

[Yufeng Shen (Slow to review), 2014-09-10 20:06:11]

miletus@chromium.org changed reviewers:
+ oshima@chromium.org

[oshima, 2014-09-10 22:17:46]

lgtm

We probably should have used scoped object patter to make sure
PostDisplayConfigurationChange gets called, but
that's outside of the scope. I'll look into it in my spare time.

[Yufeng Shen (Slow to review), 2014-09-10 22:19:08]

The CQ bit was checked by miletus@chromium.org

[commit-bot: I haz the power, 2014-09-10 22:20:58]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/miletus@chromium.org/559213002/20001

[commit-bot: I haz the power, 2014-09-11 00:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 00:23:53]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yufeng Shen (Slow to review), 2014-09-11 16:24:02]

https://codereview.chromium.org/559213002/diff/20001/ash/display/display_mana...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/559213002/diff/20001/ash/display/display_mana...
ash/display/display_manager.cc:898: if (delegate_)
hmmm, DisplayControllerTest catches this that we must pair
PreDisplayConfigurationChange with PostDisplayConfigurationChange.

Should we also call PreDisplayConfigurationChange() here  ? or should we change
the test ?

[oshima, 2014-09-11 17:19:09]

https://codereview.chromium.org/559213002/diff/20001/ash/display/display_mana...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/559213002/diff/20001/ash/display/display_mana...
ash/display/display_manager.cc:898: if (delegate_)
On 2014/09/11 16:24:02, Yufeng Shen wrote:
> hmmm, DisplayControllerTest catches this that we must pair
> PreDisplayConfigurationChange with PostDisplayConfigurationChange.
> 
> Should we also call PreDisplayConfigurationChange() here  ? or should we
change
> the test ?

Yes, it has to be paired. You can move the PreDisplay.. below

[Yufeng Shen (Slow to review), 2014-09-11 18:25:49]

https://codereview.chromium.org/559213002/diff/20001/ash/display/display_mana...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/559213002/diff/20001/ash/display/display_mana...
ash/display/display_manager.cc:898: if (delegate_)
On 2014/09/11 17:19:08, oshima wrote:
> On 2014/09/11 16:24:02, Yufeng Shen wrote:
> > hmmm, DisplayControllerTest catches this that we must pair
> > PreDisplayConfigurationChange with PostDisplayConfigurationChange.
> > 
> > Should we also call PreDisplayConfigurationChange() here  ? or should we
> change
> > the test ?
> 
> Yes, it has to be paired. You can move the PreDisplay.. below

Done.

[oshima, 2014-09-11 18:30:20]

lgtm

[Yufeng Shen (Slow to review), 2014-09-11 20:01:12]

The CQ bit was checked by miletus@chromium.org

[commit-bot: I haz the power, 2014-09-11 20:07:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/559213002/60001

[commit-bot: I haz the power, 2014-09-11 22:43:44]

Committed patchset #4 (id:60001) as 60f655f6c8df2c5b8d902563a1a42b535854048e

[commit-bot: I haz the power, 2014-09-11 22:57:56]

Patchset 4 (id:??) landed as
https://crrev.com/4802a8552a40e1f80606ca7171dc2f79930e7fb3
Cr-Commit-Position: refs/heads/master@{#294481}

[engedy, 2014-09-12 09:06:53]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/569553002/ by engedy@chromium.org.

The reason for reverting is: I am reverting this as it resulted in test
VirtualKeyboardUsabilityExperimentTest.VirtualKeyboardWindowTest consistently
crashing on Linux ChromiumOS Tests, see:

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20...

Stack trace:

Objects involved in the operation:
sequence "this" @ 0x0x3e568fbdcc90 {
}
Received signal 6
#0 0x7fcb9c8936fe base::debug::StackTrace::StackTrace()
#1 0x7fcb9c893230 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7fcb8c474cb0 \u003Cunknown>
#3 0x7fcb8bbc4425 gsignal
#4 0x7fcb8bbc7b8b abort
#5 0x7fcb8c1c75ad __gnu_debug::_Error_formatter::_M_error()
#6 0x7fcb9a306513 std::__debug::vector\u003C>::operator[]()
#7 0x7fcb9a2fbba9 ash::DisplayManager::GetCurrentDisplayIdPair()
#8 0x7fcb9a2d96cf ash::DisplayController::PostDisplayConfigurationChange()
#9 0x7fcb9a2d98bc ash::DisplayController::PostDisplayConfigurationChange()
#10 0x7fcb9a2fd22a ash::DisplayManager::UpdateDisplays()
#11 0x7fcb9a2fdbe8 ash::DisplayManager::SetDisplayRotation()
#12 0x7fcb9a33425b ash::VirtualKeyboardWindowController::FlipDisplay()
#13 0x7fcb9a3340d7 ash::VirtualKeyboardWindowController::UpdateWindow()
#14 0x7fcb9a2d92df ash::DisplayController::CreateOrUpdateNonDesktopDisplay()
#15 0x7fcb9a2d937f ash::DisplayController::CreateOrUpdateNonDesktopDisplay()
#16 0x7fcb9a300ea9 ash::(anonymous
namespace)::NonDesktopDisplayUpdater::~NonDesktopDisplayUpdater()
#17 0x7fcb9a300df1 ash::DisplayManager::CreateMirrorWindowIfAny().

[Alexander Potapenko, 2014-09-12 10:05:24]

I've filed http://crbug.com/413583 for ASan reports in the same test.

[Yufeng Shen (Slow to review), 2014-09-15 20:23:13]

On 2014/09/12 10:05:24, Alexander Potapenko wrote:
> I've filed http://crbug.com/413583 for ASan reports in the same test.

The crashing test was removed here
https://codereview.chromium.org/569323002/


I am going to reland this CL.