runtime/vm/object.cc - Issue 559203003: Fix wrong conversion from double to bigint in overriden operators of new bigint.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 559203003: Fix wrong conversion from double to bigint in overriden operators of new bigint. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

===================================================================

--- runtime/vm/object.cc (revision 40121)

+++ runtime/vm/object.cc (working copy)

@@ -16828,8 +16828,7 @@

intptr_t pos = 0;

const intptr_t kDivisor = 100000000;

const intptr_t kDigits = 8;

- // TODO(regis): Fix Windows error reported for ambiguous call to 'pow'.

- // ASSERT(pow(10.0, kDigits) == kDivisor);

+ ASSERT(pow(10.0, 1.0 * kDigits) == kDivisor);

ASSERT(kDivisor < kDigitBase);

ASSERT(Smi::IsValid(kDivisor));

// Allocate a copy of the digits.

« no previous file with comments | « runtime/lib/integers.dart ('k') | tests/co19/co19-dart2js.status » ('j') | no next file with comments »