Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 559153002: Measure picture recording speed in nanobench. (Closed)

Created:
6 years, 3 months ago by mtklein_C
Modified:
6 years, 3 months ago
Reviewers:
jcgregorio, mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Measure picture recording speed in nanobench. Today we measure SkPicture playback speed, but not the time it takes to record the SkPicture. This fixes that by reading SKPs from disk and re-recording them. On the console, recording shows up first as the nonrendering skp benches, followed later by the usual playback benches: maxrss loops min median mean max stddev samples config bench 51M 2 165µs 168µs 169µs 178µs 3% ▆▄▃█▂▄▁▂▁▁ nonrendering tabl_slashdot.skp 57M 1 9.72ms 9.77ms 9.79ms 9.97ms 1% █▂▂▅▃▂▁▄▂▁ nonrendering desk_pokemonwiki.skp 57M 32 2.92µs 2.96µs 3.03µs 3.46µs 6% ▅▁▁▁▁▁▁█▂▁ nonrendering desk_yahoosports.skp ... 147M 1 3.86ms 3.87ms 3.97ms 4.81ms 7% █▁▁▁▁▁▁▁▁▁ 8888 tabl_slashdot.skp_1 147M 1 4.54ms 4.56ms 4.55ms 4.56ms 0% █▅▇▅█▅▂▁▅▁ 565 tabl_slashdot.skp_1 147M 2 3.08ms 3.24ms 4.17ms 8.18ms 50% █▁▁█▁▁▁▁▁▁ gpu tabl_slashdot.skp_1 147M 1 1.61ms 1.62ms 1.69ms 2.33ms 13% █▁▁▁▁▁▁▁▁▁ 8888 desk_pokemonwiki.skp_1 147M 1 1.44ms 1.44ms 1.45ms 1.47ms 1% ▅▂█▂▂▅▁▁▂▁ 565 desk_pokemonwiki.skp_1 ... On skiaperf.com, they'll also be separated out from playback benches by bench_type. BUG=skia: Committed: https://skia.googlesource.com/skia/+/fd731ce804cd3223318f3feee2c98404890b65f2

Patch Set 1 #

Patch Set 2 : Support --bbh/--nobbh. #

Patch Set 3 : spin off bench_type #

Patch Set 4 : scalars and ints #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -21 lines) Patch
A bench/RecordingBench.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
A bench/RecordingBench.cpp View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
M bench/nanobench.cpp View 1 2 3 4 7 chunks +47 lines, -21 lines 0 comments Download
M gyp/bench.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/iOSShell.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
mtklein
6 years, 3 months ago (2014-09-10 17:39:56 UTC) #2
mtklein
Joe's reminded me skiaperf.com will be better if we don't pun source_type. I've added bench_type.
6 years, 3 months ago (2014-09-10 17:53:33 UTC) #4
jcgregorio
On 2014/09/10 17:53:33, mtklein wrote: > Joe's reminded me http://skiaperf.com will be better if we ...
6 years, 3 months ago (2014-09-10 18:12:26 UTC) #5
reed1
lgtm
6 years, 3 months ago (2014-09-10 18:58:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/559153002/40001
6 years, 3 months ago (2014-09-10 18:59:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/559153002/80001
6 years, 3 months ago (2014-09-10 19:11:15 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 19:19:35 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as fd731ce804cd3223318f3feee2c98404890b65f2

Powered by Google App Engine
This is Rietveld 408576698