Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1412)

Issue 559143003: Thread the Lithium instruction down to DeoptimizeIf and friends. (Closed)

Created:
6 years, 3 months ago by Sven Panne
Modified:
6 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Thread the Lithium instruction down to DeoptimizeIf and friends. This is a purely mechanical refactoring and a first step towards being able to report more helpful deoptimization reasons. With this refactoring, we know at least the mnemonic of the instruction causing the deopt, although this is not used yet. Future steps will be using the mnemonic, passing additional explicit deopt reasons and removing the fragile machinery of searching for code comments. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24026

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+805 lines, -929 lines) Patch
M src/arm/lithium-codegen-arm.h View 2 chunks +4 lines, -9 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 78 chunks +105 lines, -109 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.h View 1 chunk +17 lines, -20 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 72 chunks +125 lines, -146 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 2 chunks +4 lines, -11 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 80 chunks +108 lines, -117 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 2 chunks +4 lines, -10 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 72 chunks +107 lines, -124 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 2 chunks +4 lines, -10 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 73 chunks +110 lines, -131 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 2 chunks +4 lines, -10 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 80 chunks +108 lines, -113 lines 0 comments Download
M src/x87/lithium-codegen-x87.h View 2 chunks +5 lines, -11 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 72 chunks +100 lines, -108 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Sven Panne
6 years, 3 months ago (2014-09-18 08:34:40 UTC) #3
Jakob Kummerow
lgtm
6 years, 3 months ago (2014-09-18 09:43:53 UTC) #4
Sven Panne
6 years, 3 months ago (2014-09-18 09:53:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as 24026 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698