Shrink the binary by not super inlining all string concatenations.

Shrink the binary by not super inlining all string concatenations.

String concatenation is used a lot to build error and exception
messages and it was larger than intended because of over eager
inlining.

Outlining template code saves 90 KB with clang and 65 KB with
gcc (lin64 content_shell). After this there is roughly 60 KB of
concatenation code left (clang).

clang:
Total change: -91866 bytes
==========================
  47 added, totalling +6264 bytes across 3 sources
  38 removed, totalling -18354 bytes across 2 sources
  79 grown, for a net change of +4604 bytes (98534 bytes before, 103138 bytes after) across 50 sources
  405 shrunk, for a net change of -84380 bytes (370130 bytes before, 285750 bytes after) across 134 sources

gcc:
Total change: -66849 bytes
==========================
  333 added, totalling +81561 bytes across 69 sources
  203 removed, totalling -65785 bytes across 76 sources
  211 grown, for a net change of +18666 bytes (228381 bytes before, 247047 bytes after) across 85 sources
  406 shrunk, for a net change of -101291 bytes (568083 bytes before, 466792 bytes after) across 160 sources

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181896

[Daniel Bratell, 2014-09-10 16:35:58]

Patchset #1 (id:1) has been deleted

[Daniel Bratell, 2014-09-10 16:50:13]

bratell@opera.com changed reviewers:
+ fs@opera.com, jochen@chromium.org

[Daniel Bratell, 2014-09-10 16:50:13]

jochen, can you please take a look, or redirect me to someone else if you think
someone else would be more suited looking at the code (it's not something people
touch often)?

[jochen (gone - plz use gerrit), 2014-09-12 07:55:23]

lgtm.

[Daniel Bratell, 2014-09-12 12:43:11]

The CQ bit was checked by bratell@opera.com

[commit-bot: I haz the power, 2014-09-12 12:43:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/559133002/20001

[commit-bot: I haz the power, 2014-09-12 12:48:17]

Committed patchset #1 (id:20001) as 181896

[Nico, 2016-10-01 16:47:29]

thakis@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2016-10-01 16:47:30]

https://codereview.chromium.org/559133002/diff/20001/Source/wtf/text/StringCo...
File Source/wtf/text/StringConcatenate.h (left):

https://codereview.chromium.org/559133002/diff/20001/Source/wtf/text/StringCo...
Source/wtf/text/StringConcatenate.h:347:
WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING();
FWIW, this made parts of StringOperatorsTest.cpp fairly pointless since that
test redefines the macro before including the header. Not sure what to do about
this; maybe the two functions using the macro should move back to the header?