Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 55913004: Reland "Enable SysInfo::AmountOfPhysicalMemory to be called from within the Linux Sandbox" (Closed)

Created:
7 years, 1 month ago by rmcilroy
Modified:
7 years, 1 month ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reland "Enable SysInfo::AmountOfPhysicalMemory to be called from within the Linux Sandbox" Trigger caching of SysInfo::AmountOfPhysicalMemory in PreSandboxInit() to enable it to be called by the renderer process after the sandbox is sealed. BUG=312241 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232790

Patch Set 1 #

Patch Set 2 : Seperate MaxSharedMemorySize and AmountOfPhysicalMemory initialization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -24 lines) Patch
M base/sys_info.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/sys_info_linux.cc View 1 2 chunks +51 lines, -23 lines 0 comments Download
M content/zygote/zygote_main_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
rmcilroy
Apologies but my previous reland didn't fix the underlying issue on WebKit_tests properly. This should ...
7 years, 1 month ago (2013-11-01 22:06:34 UTC) #1
jar (doing other things)
lgtm
7 years, 1 month ago (2013-11-01 23:34:18 UTC) #2
jln (very slow on Chromium)
Zygote lgtm
7 years, 1 month ago (2013-11-02 00:44:34 UTC) #3
rmcilroy
On 2013/11/02 00:44:34, jln wrote: > Zygote lgtm Thanks!
7 years, 1 month ago (2013-11-04 07:45:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/55913004/30001
7 years, 1 month ago (2013-11-04 07:45:13 UTC) #5
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97111
7 years, 1 month ago (2013-11-04 10:17:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/55913004/30001
7 years, 1 month ago (2013-11-04 10:19:27 UTC) #7
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97138
7 years, 1 month ago (2013-11-04 12:27:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/55913004/30001
7 years, 1 month ago (2013-11-04 13:41:36 UTC) #9
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-04 15:04:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmcilroy@chromium.org/55913004/30001
7 years, 1 month ago (2013-11-04 17:46:29 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-04 20:50:21 UTC) #12
Message was sent while issue was closed.
Change committed as 232790

Powered by Google App Engine
This is Rietveld 408576698