Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 559113002: Truncate process_name if greater than 50 charcters (Closed)

Created:
6 years, 3 months ago by paulwhitton
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] memory_inspector: truncate process_name in CLI dumps. If process_name is greater than 50 characters, display truncated process_name BUG=340294 NOTRY=true Committed: https://crrev.com/2a3abf4b24bce7692cf41f0092934b6e48a19dee Cr-Commit-Position: refs/heads/master@{#295275}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Code change following review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M tools/memory_inspector/memory_inspector/frontends/command_line.py View 1 3 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
paulwhitton
Hi Primiano, Here is the change to display a truncated process_name if the length is ...
6 years, 3 months ago (2014-09-10 15:03:58 UTC) #2
Primiano Tucci (use gerrit)
https://codereview.chromium.org/559113002/diff/1/tools/memory_inspector/memory_inspector/frontends/command_line.py File tools/memory_inspector/memory_inspector/frontends/command_line.py (right): https://codereview.chromium.org/559113002/diff/1/tools/memory_inspector/memory_inspector/frontends/command_line.py#newcode128 tools/memory_inspector/memory_inspector/frontends/command_line.py:128: display_process_name = process.name What about making these 3 lines ...
6 years, 3 months ago (2014-09-11 14:51:00 UTC) #4
paulwhitton
Hi Primiano, Here are the changes following the review for you to review. Cheers Paul
6 years, 3 months ago (2014-09-15 11:59:30 UTC) #6
Primiano Tucci (use gerrit)
LGTM Just please fix the first line of the commit message to be [Android] memory_inspector: ...
6 years, 3 months ago (2014-09-15 14:27:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559113002/20001
6 years, 3 months ago (2014-09-17 14:42:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 47935878bfcd27ef5d277d8c7cfbe69bcf5e0937
6 years, 3 months ago (2014-09-17 14:43:05 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-17 14:43:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2a3abf4b24bce7692cf41f0092934b6e48a19dee
Cr-Commit-Position: refs/heads/master@{#295275}

Powered by Google App Engine
This is Rietveld 408576698