Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 559103003: Cleanup: Remove Dispatcher and UserScript classes from builds where extensions are disabled. (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, darin-cc_chromium.org, jam, derat+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove Dispatcher and UserScript classes from builds where extensions are disabled. BUG=402728 Committed: https://crrev.com/9502c6444d6556c8decf0be33e9537398edcb6e3 Cr-Commit-Position: refs/heads/master@{#294713}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -22 lines) Patch
M chrome/renderer/chrome_content_renderer_client.h View 5 chunks +12 lines, -0 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 30 chunks +51 lines, -13 lines 0 comments Download
M chrome/renderer/extensions/extension_frame_helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/renderer/pepper/pepper_uma_host.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 6 chunks +16 lines, -9 lines 0 comments Download
M extensions/extensions.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Lei Zhang
The extensions on android removal shall continue!
6 years, 3 months ago (2014-09-12 23:36:16 UTC) #3
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-12 23:45:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559103003/20001
6 years, 3 months ago (2014-09-13 00:01:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001) as 44d8337f56e9e54d718bd01336d027607879e101
6 years, 3 months ago (2014-09-13 01:05:08 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 01:17:37 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9502c6444d6556c8decf0be33e9537398edcb6e3
Cr-Commit-Position: refs/heads/master@{#294713}

Powered by Google App Engine
This is Rietveld 408576698