Source/platform/graphics/ImageBuffer.cpp - Issue 559103002: Reduce memory peaks when generating data urls for images.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/ImageBuffer.cpp

Issue 559103002: Reduce memory peaks when generating data urls for images. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: toDataURL - now without freeing Vector early. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/graphics/ImageBuffer.cpp

diff --git a/Source/platform/graphics/ImageBuffer.cpp b/Source/platform/graphics/ImageBuffer.cpp

index 4ea1880db0cb0eac0d88abebf9010ad21787cf92..49e29c6a076da1157db81071d5b4d15460f01e00 100644

--- a/Source/platform/graphics/ImageBuffer.cpp

+++ b/Source/platform/graphics/ImageBuffer.cpp

@@ -420,10 +420,7 @@ String ImageBuffer::toDataURL(const String& mimeType, const double* quality) con

Vector<char> encodedImage;

if (!isSurfaceValid() || !encodeImage(m_surface->bitmap(), mimeType, quality, &encodedImage))

return "data:,";

- Vector<char> base64Data;

- base64Encode(encodedImage, base64Data);

- return "data:" + mimeType + ";base64," + base64Data;

+ return "data:" + mimeType + ";base64," + base64Encode(encodedImage);

Noel Gordon 2014/09/12 15:23:42 nit - space before this line.

}

String ImageDataToDataURL(const ImageDataBuffer& imageData, const String& mimeType, const double* quality)

@@ -434,10 +431,7 @@ String ImageDataToDataURL(const ImageDataBuffer& imageData, const String& mimeTy

if (!encodeImage(imageData, mimeType, quality, &encodedImage))

return "data:,";

- Vector<char> base64Data;

- base64Encode(encodedImage, base64Data);

- return "data:" + mimeType + ";base64," + base64Data;

+ return "data:" + mimeType + ";base64," + base64Encode(encodedImage);

}

} // namespace blink

« no previous file with comments | « Source/core/inspector/InspectorLayerTreeAgent.cpp ('k') | no next file » | no next file with comments »