Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 559053003: Add google_apis.gyp:google_apis_unittests to iOS build (Closed)

Created:
6 years, 3 months ago by msarda
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add google_apis.gyp:google_apis_unittests to iOS build BUG=NONE Committed: https://crrev.com/13a866a466e38ed2a1df82d5f57be9713ebba80c Cr-Commit-Position: refs/heads/master@{#295046}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
msarda
Please take a look.
6 years, 3 months ago (2014-09-11 09:10:53 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
6 years, 3 months ago (2014-09-15 17:50:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559053003/1
6 years, 3 months ago (2014-09-15 18:02:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/4575) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/4436) chromium_presubmit ...
6 years, 3 months ago (2014-09-15 19:35:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559053003/20001
6 years, 3 months ago (2014-09-16 08:16:57 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-16 10:17:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559053003/20001
6 years, 3 months ago (2014-09-16 11:06:17 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1c055ea6c2f4a353ed34cdc2b3c55ad28e14f098
6 years, 3 months ago (2014-09-16 11:47:47 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 11:49:06 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/13a866a466e38ed2a1df82d5f57be9713ebba80c
Cr-Commit-Position: refs/heads/master@{#295046}

Powered by Google App Engine
This is Rietveld 408576698