Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 559033002: Updated the documentation of the SafeSearch policy. (Closed)

Created:
6 years, 3 months ago by Joao da Silva
Modified:
6 years, 3 months ago
CC:
chromium-reviews, joaodasilva+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Updated the documentation of the SafeSearch policy. Since Chrome 38, this policy is also forcing Safety Mode for YouTube. BUG=344815 Committed: https://crrev.com/2ff9399027f8473add7f420c1d7fe68c73692694 Cr-Commit-Position: refs/heads/master@{#294740}

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/policy/resources/policy_templates.json View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Joao da Silva
PTAL, thanks!
6 years, 3 months ago (2014-09-10 11:56:54 UTC) #2
pneubeck (no reviews)
lgtm https://codereview.chromium.org/559033002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/559033002/diff/1/components/policy/resources/policy_templates.json#newcode799 components/policy/resources/policy_templates.json:799: 'desc': '''Forces queries in Google Web Search to ...
6 years, 3 months ago (2014-09-10 12:14:59 UTC) #3
Joao da Silva
https://codereview.chromium.org/559033002/diff/1/components/policy/resources/policy_templates.json File components/policy/resources/policy_templates.json (right): https://codereview.chromium.org/559033002/diff/1/components/policy/resources/policy_templates.json#newcode799 components/policy/resources/policy_templates.json:799: 'desc': '''Forces queries in Google Web Search to be ...
6 years, 3 months ago (2014-09-10 12:24:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/559033002/20001
6 years, 3 months ago (2014-09-10 12:25:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/13934)
6 years, 3 months ago (2014-09-10 12:35:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/559033002/20001
6 years, 3 months ago (2014-09-13 07:22:17 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as c744d3cb0291c63a6e66847196c7a328730b761c
6 years, 3 months ago (2014-09-13 07:27:13 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-13 07:29:07 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ff9399027f8473add7f420c1d7fe68c73692694
Cr-Commit-Position: refs/heads/master@{#294740}

Powered by Google App Engine
This is Rietveld 408576698