content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc - Issue 559003002: Fix ServiceWorkerCache::Keys() unittest memory leak.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

Issue 559003002: Fix ServiceWorkerCache::Keys() unittest memory leak. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_cache.cc ('k') | content/browser/service_worker/service_worker_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

diff --git a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

index dfee904f99eb55ba533f9c8ca2d9cb58266edf7a..afdb4ef7fc9e7c0fa8351dbc313433a8dcab15aa 100644

--- a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

+++ b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

@@ -12,6 +12,7 @@

#include "content/public/browser/browser_thread.h"

#include "content/public/test/test_browser_context.h"

#include "content/public/test/test_browser_thread_bundle.h"

+#include "net/disk_cache/simple/simple_backend_impl.h"

#include "net/url_request/url_request_context_getter.h"

#include "storage/browser/blob/blob_storage_context.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -50,6 +51,16 @@ class ServiceWorkerCacheStorageManagerTest : public testing::Test {

url_request_context, blob_storage_context->context()->AsWeakPtr());

}

+ virtual void TearDown() OVERRIDE {

+ base::RunLoop().RunUntilIdle();

+ disk_cache::SimpleBackendImpl::FlushWorkerPoolForTesting();

+ base::RunLoop().RunUntilIdle();

+ cache_manager_.reset();

+ base::RunLoop().RunUntilIdle();

+ disk_cache::SimpleBackendImpl::FlushWorkerPoolForTesting();

+ base::RunLoop().RunUntilIdle();

+ }

virtual bool MemoryOnly() { return false; }

void BoolAndErrorCallback(