Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 558943002: Revert of Cross-process iframe accessibility. (Closed)

Created:
6 years, 3 months ago by dconnelly
Modified:
6 years, 3 months ago
CC:
chromium-reviews, creis+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nasko+codewatch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Revert of Cross-process iframe accessibility. (patchset #19 id:360001 of https://codereview.chromium.org/268543008/) Reason for revert: Broke Mac tests: http://build.chromium.org/p/chromium.mac/builders/Mac10.7%20Tests%20%281%29/builds/26131 http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg%29%281%29/builds/52684 http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/26975 http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg%29%281%29/builds/26976 and so on. Original issue's description: > Cross-process iframe accessibility. > > This change completes the plumbing to join cross-process iframes into a single composed accessibility tree on platforms that implement native accessibility APIs (Windows, Mac, Android). > > Further work will be needed to update some accessibility API implementations to be multi-frame-aware. > > BUG=368298 > > Committed: https://crrev.com/387942c041da17ea6337bc0a81e96619e67e4ac4 > Cr-Commit-Position: refs/heads/master@{#294118} TBR=creis@chromium.org,dtseng@chromium.org,aboxhall@chromium.org,nick@chromium.org,nasko@chromium.org,dmazzoni@chromium.org NOTREECHECKS=true NOTRY=true BUG=368298 Committed: https://crrev.com/1dcb3ab78bde4c56037d79ac58d73fb2fca8a39b Cr-Commit-Position: refs/heads/master@{#294135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -557 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility.h View 3 chunks +7 lines, -19 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 5 chunks +2 lines, -30 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.h View 7 chunks +17 lines, -19 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager.cc View 4 chunks +2 lines, -67 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_unittest.cc View 1 chunk +0 lines, -7 lines 0 comments Download
D content/browser/accessibility/site_per_process_accessibility_browsertest.cc View 1 chunk +0 lines, -144 lines 0 comments Download
M content/browser/frame_host/frame_tree.cc View 3 chunks +18 lines, -18 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 4 chunks +1 line, -69 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.h View 2 chunks +0 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_proxy_host.cc View 5 chunks +1 line, -29 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 2 chunks +3 lines, -3 lines 0 comments Download
D content/browser/site_per_process_browsertest.h View 1 chunk +0 lines, -29 lines 0 comments Download
M content/browser/site_per_process_browsertest.cc View 3 chunks +40 lines, -38 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/common/accessibility_messages.h View 1 chunk +0 lines, -7 lines 0 comments Download
M content/content_tests.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.h View 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 6 chunks +6 lines, -27 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M content/renderer/accessibility/renderer_accessibility_complete.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/accessibility_browser_test_utils.h View 2 chunks +1 line, -3 lines 0 comments Download
M content/test/accessibility_browser_test_utils.cc View 2 chunks +6 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dconnelly
Created Revert of Cross-process iframe accessibility.
6 years, 3 months ago (2014-09-10 07:42:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dconnelly@chromium.org/558943002/1
6 years, 3 months ago (2014-09-10 07:43:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 77ca0cd16e0d78887e053f067cd8c5a3207f5f1e
6 years, 3 months ago (2014-09-10 07:45:16 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 07:52:31 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1dcb3ab78bde4c56037d79ac58d73fb2fca8a39b
Cr-Commit-Position: refs/heads/master@{#294135}

Powered by Google App Engine
This is Rietveld 408576698