chrome/browser/ui/views/omnibox/omnibox_view_views.cc - Issue 55893004: Omnibox selects all text on tap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

Issue 55893004: Omnibox selects all text on tap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address pkasting's comments. Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/omnibox/omnibox_view_views.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

index e55f4a26106abbcc2cc796d1536303e51dc2cb7f..c2a505de525b96e9a64363a46c0429b283fd35d5 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views.cc

@@ -198,7 +198,8 @@ void OmniboxViewViews::OnGestureEvent(ui::GestureEvent* event) {

}

if (select_all_on_gesture_tap_ && event->type() == ui::ET_GESTURE_TAP)

SelectAll(false);

- select_all_on_gesture_tap_ = false;

+ if (event->type() != ui::ET_GESTURE_SHOW_PRESS)

+ select_all_on_gesture_tap_ = false;

}

void OmniboxViewViews::GetAccessibleState(ui::AccessibleViewState* state) {