chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc - Issue 558913003: Remove clipboard argument from ScopedClipboardWriter constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

Issue 558913003: Remove clipboard argument from ScopedClipboardWriter constructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't leak a clipboard on Windows Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

diff --git a/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc b/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

index 66f6731e44cad8611b3f5ca29f5c53031243b46b..c1fadaff838e881aac7e5663349ac7edb514f036 100644

--- a/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

+++ b/chrome/browser/ui/views/omnibox/omnibox_view_views_browsertest.cc

@@ -107,8 +107,7 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest, PasteAndGoDoesNotLeavePopupOpen) {

// Put an URL on the clipboard.

{

- ui::ScopedClipboardWriter clipboard_writer(

- ui::Clipboard::GetForCurrentThread(), ui::CLIPBOARD_TYPE_COPY_PASTE);

+ ui::ScopedClipboardWriter clipboard_writer(ui::CLIPBOARD_TYPE_COPY_PASTE);

clipboard_writer.WriteURL(base::ASCIIToUTF16("http://www.example.com/"));

}

@@ -307,7 +306,6 @@ IN_PROC_BROWSER_TEST_F(OmniboxViewViewsTest,

// of the writer.

{

ui::ScopedClipboardWriter clipboard_writer(

- ui::Clipboard::GetForCurrentThread(),

ui::CLIPBOARD_TYPE_COPY_PASTE);

clipboard_writer.WriteURL(base::ASCIIToUTF16("http://www.example.com/"));

}

« no previous file with comments | « chrome/browser/ui/views/omnibox/omnibox_view_views.cc ('k') | chrome/common/net/url_util.h » ('j') | no next file with comments »