Remove clipboard argument from ScopedClipboardWriter constructor.

ui/base/clipboard/scoped_clipboard_writer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file declares the ScopedClipboardWriter class, a wrapper around
 // the Clipboard class which simplifies writing data to the system clipboard.
-// Upon deletion the class atomically writes all data to |clipboard_|,
+// Upon deletion the class atomically writes all data to the clipboard,
 // avoiding any potential race condition with other processes that are also
 // writing to the system clipboard.
 
 #ifndef UI_BASE_CLIPBOARD_SCOPED_CLIPBOARD_WRITER_H_
 #define UI_BASE_CLIPBOARD_SCOPED_CLIPBOARD_WRITER_H_
 
 #include <string>
 
 #include "base/strings/string16.h"
 #include "ui/base/clipboard/clipboard.h"
 #include "ui/base/ui_base_export.h"
 
 class Pickle;
 
 namespace ui {
 
 // This class is a wrapper for |Clipboard| that handles packing data
 // into a Clipboard::ObjectMap.
 class UI_BASE_EXPORT ScopedClipboardWriter {
  public:
-  // Create an instance that is a simple wrapper around clipboard.
-  ScopedClipboardWriter(Clipboard* clipboard, ClipboardType type);
+  // Create an instance that is a simple wrapper around the clipboard of the
+  // given type.
+  explicit ScopedClipboardWriter(ClipboardType type);
 
   ~ScopedClipboardWriter();
 
   // Converts |text| to UTF-8 and adds it to the clipboard.
   void WriteText(const base::string16& text);
 
   // Converts the text of the URL to UTF-8 and adds it to the clipboard, then
   // notifies the Clipboard that we just wrote a URL.
   void WriteURL(const base::string16& text);
 
@@ skipping 23 matching lines @@
   // Removes all objects that would be written to the clipboard.
   void Reset();
 
  protected:
   // Converts |text| to UTF-8 and adds it to the clipboard.  If it's a URL, we
   // also notify the clipboard of that fact.
   void WriteTextOrURL(const base::string16& text, bool is_url);
 
   // We accumulate the data passed to the various targets in the |objects_|
   // vector, and pass it to Clipboard::WriteObjects() during object destruction.
   Clipboard::ObjectMap objects_;

[sky, 2014/09/17 15:41:50]

style guide says members should be private.

[dcheng, 2014/09/17 17:10:48]

Yeah, ScopedClipboardWriterGlue directly modifies this atm. That will be fixed
soon by the CL I linked in my initial email.

-  Clipboard* clipboard_;
-  ClipboardType type_;
+  const ClipboardType type_;
 
   // We keep around the UTF-8 text of the URL in order to pass it to
   // Clipboard::DidWriteURL().
   std::string url_text_;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(ScopedClipboardWriter);
 };
 
 }  // namespace ui
 
 #endif  // UI_BASE_CLIPBOARD_SCOPED_CLIPBOARD_WRITER_H_