Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 558903003: Invalidate input buffer index after releasing MediaCodecBridge (Closed)

Created:
6 years, 3 months ago by qinmin
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Invalidate input buffer index after releasing MediaCodecBridge We should invalidate the input buffer index, or otherwise the new MediaCodec will call queueInputBuffer on an unitialized buffer Committed: https://crrev.com/aeebeacef84b20792fed6c795de9b526af76f811 Cr-Commit-Position: refs/heads/master@{#294596}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/base/android/media_decoder_job.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
qinmin
PTAL This seems a valid issue, even if it is not a culprit of the ...
6 years, 3 months ago (2014-09-11 01:07:09 UTC) #2
xhwang
looking good, but it'll be nice to make sure this fixes the bug we saw. ...
6 years, 3 months ago (2014-09-11 03:47:10 UTC) #4
gunsch
On 2014/09/11 03:47:10, xhwang wrote: > looking good, but it'll be nice to make sure ...
6 years, 3 months ago (2014-09-12 00:03:27 UTC) #5
wjia1
On 2014/09/11 03:47:10, xhwang wrote: > looking good, but it'll be nice to make sure ...
6 years, 3 months ago (2014-09-12 00:53:15 UTC) #6
xhwang
On 2014/09/12 00:53:15, wjia1 wrote: > On 2014/09/11 03:47:10, xhwang wrote: > > looking good, ...
6 years, 3 months ago (2014-09-12 07:36:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558903003/1
6 years, 3 months ago (2014-09-12 14:39:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 03eac6cf03ca1ccaf5755c6b48b239fd0f2d181c
6 years, 3 months ago (2014-09-12 15:42:32 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 15:48:47 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aeebeacef84b20792fed6c795de9b526af76f811
Cr-Commit-Position: refs/heads/master@{#294596}

Powered by Google App Engine
This is Rietveld 408576698