Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 5589004: Merge 73319 - 2010-12-03 Dimitri Glazkov <dglazkov@chromium.org>... (Closed)

Created:
9 years, 10 months ago by dglazkov
Modified:
9 years, 4 months ago
Reviewers:
dglazkov
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/597/
Visibility:
Public.

Description

Merge 73319 - 2010-12-03 Dimitri Glazkov <dglazkov@chromium.org>; Reviewed by Darin Adler. REGRESSION(r71934): input event fires twice when editing text inside a text input. https://bugs.webkit.org/show_bug.cgi?id=50477 * fast/forms/text-input-event-expected.txt: Added. * fast/forms/text-input-event.html: Added. 2010-12-03 Dimitri Glazkov <dglazkov@chromium.org>; Reviewed by Darin Adler. REGRESSION(r71934): input event fires twice when editing text inside a text input. https://bugs.webkit.org/show_bug.cgi?id=50477 Now that events escape the shadow DOM boundary, the input event is fired twice for each input, once triggered by editing, once triggered by value change. Test: fast/forms/text-input-event.html * dom/InputElement.cpp: (WebCore::InputElement::setValueFromRenderer): Added a check to ensure editable fields don't fire an extra input event. BUG=64750 TBR=dglazkov@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+614 lines, --1 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +192 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/text-input-event.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/forms/text-input-event-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M WebCore/ChangeLog View 1 chunk +421 lines, -0 lines 0 comments Download
M WebCore/dom/InputElement.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
dglazkov
9 years, 10 months ago (2010-12-06 16:49:20 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698