[Android] Allow instrumentation test skipping.

[Android] Allow instrumentation test skipping.

This patch also removes a call to AdbInterface.StartInstrumentation and
implements some of the functionality of am_instrument_parser.py.

BUG=408585
Committed: https://crrev.com/cbcc115def0fe5d2cf4c2018fccbbc16fd4c5aba
Cr-Commit-Position: refs/heads/master@{#295491}

[jbudorick, 2014-09-17 22:17:14]

jbudorick@chromium.org changed reviewers:
+ klundberg@chromium.org, mikecase@chromium.org, rnephew@chromium.org

[jbudorick, 2014-09-17 22:27:30]

On 2014/09/17 22:17:15, jbudorick wrote:

working on adding unit tests. they'll be in the next patch set.

[klundberg, 2014-09-18 15:35:05]

LGTM with minor comment.

Thanks for adding the tests!

https://codereview.chromium.org/558883003/diff/20001/build/android/pylib/inst...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/558883003/diff/20001/build/android/pylib/inst...
build/android/pylib/instrumentation/test_runner.py:420: bundle[k] = '\n'.join(v)
Minor thing but it seems a bit weird to me to add "\n" (/formatting here). It
seems like that should be handled when the strings are output (so basically in
_GenerateTestResult).

[jbudorick, 2014-09-18 16:13:01]

jbudorick@chromium.org changed reviewers:
+ craigdh@chromium.org

[jbudorick, 2014-09-18 16:13:02]

https://codereview.chromium.org/558883003/diff/20001/build/android/pylib/inst...
File build/android/pylib/instrumentation/test_runner.py (right):

https://codereview.chromium.org/558883003/diff/20001/build/android/pylib/inst...
build/android/pylib/instrumentation/test_runner.py:420: bundle[k] = '\n'.join(v)
On 2014/09/18 15:35:05, klundberg wrote:
> Minor thing but it seems a bit weird to me to add "\n" (/formatting here). It
> seems like that should be handled when the strings are output (so basically in
> _GenerateTestResult).

Done.

[craigdh, 2014-09-18 16:30:15]

lgtm w/ nit

https://codereview.chromium.org/558883003/diff/40001/build/android/pylib/base...
File build/android/pylib/base/base_test_result.py (right):

https://codereview.chromium.org/558883003/diff/40001/build/android/pylib/base...
build/android/pylib/base/base_test_result.py:107: all_failures = (self.GetFail()
| self.GetCrash() | self.GetTimeout() |
nit: explicitly use union()

https://codereview.chromium.org/558883003/diff/40001/build/android/pylib/base...
build/android/pylib/base/base_test_result.py:109: if len(all_failures):
"if len(all_failures)" is the same as "if all_failures"

[jbudorick, 2014-09-18 16:52:18]

https://codereview.chromium.org/558883003/diff/40001/build/android/pylib/base...
File build/android/pylib/base/base_test_result.py (right):

https://codereview.chromium.org/558883003/diff/40001/build/android/pylib/base...
build/android/pylib/base/base_test_result.py:107: all_failures = (self.GetFail()
| self.GetCrash() | self.GetTimeout() |
On 2014/09/18 16:30:15, craigdh wrote:
> nit: explicitly use union()

Done.

https://codereview.chromium.org/558883003/diff/40001/build/android/pylib/base...
build/android/pylib/base/base_test_result.py:109: if len(all_failures):
On 2014/09/18 16:30:15, craigdh wrote:
> "if len(all_failures)" is the same as "if all_failures"

Done.

[jbudorick, 2014-09-18 16:52:25]

The CQ bit was checked by jbudorick@chromium.org

[commit-bot: I haz the power, 2014-09-18 16:53:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/558883003/60001

[commit-bot: I haz the power, 2014-09-18 17:51:08]

Committed patchset #4 (id:60001) as 2107c45193821734b2ab1f13133dedf02eacdd2a

[commit-bot: I haz the power, 2014-09-18 17:51:50]

Patchset 4 (id:??) landed as
https://crrev.com/cbcc115def0fe5d2cf4c2018fccbbc16fd4c5aba
Cr-Commit-Position: refs/heads/master@{#295491}