Better coordinate what's responsible for associating a registration to a document. During navigatio…

Better coordinate what's responsible for associating a registration to a document. During navigation, its the ServiceWorkerControlleeRequestHandler responsibility, but the ServiceWorkerRegisterJob takes over there after.

Committed: https://crrev.com/d3a8ce4877483c59b6d998cc052cd9e344d30849
Cr-Commit-Position: refs/heads/master@{#294457}

[michaeln, 2014-09-10 01:49:11]

michaeln@chromium.org changed reviewers:
+ nhiroki@chromium.org

[michaeln, 2014-09-10 01:49:12]

ptal

[michaeln, 2014-09-10 01:53:19]

i'll have to rebase with you're patches in flight

[nhiroki, 2014-09-10 02:04:11]

LGTM, thanks!

I'm not able to work on my patch for a while (due to commuting), so it's okay to
land this first :)

https://codereview.chromium.org/558873003/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_controllee_request_handler.cc
(right):

https://codereview.chromium.org/558873003/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_controllee_request_handler.cc:190:

nit: there is an extra empty line

[michaeln, 2014-09-10 02:08:41]

thnx! i'll see what's on trunk tomorrow and rebase as needed

[michaeln, 2014-09-10 22:40:40]

https://codereview.chromium.org/558873003/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_controllee_request_handler.cc
(right):

https://codereview.chromium.org/558873003/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_controllee_request_handler.cc:190:

On 2014/09/10 02:04:11, nhiroki wrote:
> nit: there is an extra empty line

Done.

[michaeln, 2014-09-10 22:40:43]

The CQ bit was checked by michaeln@chromium.org

[michaeln, 2014-09-10 22:45:51]

The CQ bit was unchecked by michaeln@chromium.org

[michaeln, 2014-09-10 23:57:21]

hi again, ptal

I narrowed the window of time the request handler sets allow_assocation_ to
false. As coded now, its set to true by the time script is executing in the
page.

[nhiroki, 2014-09-11 01:15:53]

On 2014/09/10 23:57:21, michaeln wrote:
> hi again, ptal
> 
> I narrowed the window of time the request handler sets allow_assocation_ to
> false. As coded now, its set to true by the time script is executing in the
> page.

lgtm 2!

[michaeln, 2014-09-11 19:05:59]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-09-11 19:07:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/558873003/60001

[commit-bot: I haz the power, 2014-09-11 20:28:42]

Committed patchset #4 (id:60001) as 8795d1f002600941fcbdce5f168171012f3ce629

[commit-bot: I haz the power, 2014-09-11 20:42:28]

Patchset 4 (id:??) landed as
https://crrev.com/d3a8ce4877483c59b6d998cc052cd9e344d30849
Cr-Commit-Position: refs/heads/master@{#294457}