Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 558873002: Moves NetworkMetricsProvider to //components/metrics. (Closed)

Created:
6 years, 3 months ago by gunsch
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Moves NetworkMetricsProvider to //components/metrics. R=stevenjb@chromium.org,asvitkine@chromium.org,benchan@chromium.org BUG=404791 Committed: https://crrev.com/043f36003d1d0a36be39f7eb071eeab5970d6300 Cr-Commit-Position: refs/heads/master@{#294466}

Patch Set 1 #

Patch Set 2 : remove content/ dependency #

Total comments: 4

Patch Set 3 : addressed asvitkine comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -559 lines) Patch
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
D chrome/browser/metrics/network_metrics_provider.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chrome/browser/metrics/network_metrics_provider.cc View 1 chunk +0 lines, -228 lines 0 comments Download
D chrome/browser/metrics/wifi_access_point_info_provider.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/metrics/wifi_access_point_info_provider.cc View 1 chunk +0 lines, -21 lines 0 comments Download
D chrome/browser/metrics/wifi_access_point_info_provider_chromeos.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/metrics/wifi_access_point_info_provider_chromeos.cc View 1 chunk +0 lines, -118 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +0 lines, -6 lines 0 comments Download
M components/metrics.gypi View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M components/metrics/BUILD.gn View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M components/metrics/net/DEPS View 1 1 chunk +2 lines, -0 lines 0 comments Download
A + components/metrics/net/network_metrics_provider.h View 1 4 chunks +10 lines, -5 lines 0 comments Download
A + components/metrics/net/network_metrics_provider.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + components/metrics/net/wifi_access_point_info_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/metrics/net/wifi_access_point_info_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/metrics/net/wifi_access_point_info_provider_chromeos.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + components/metrics/net/wifi_access_point_info_provider_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (1 generated)
gunsch
FYI: stevenjb@/asvitkine@ for moving the code itself benchan@ for third_party/cros_system_api (see DEPS)
6 years, 3 months ago (2014-09-10 00:43:51 UTC) #1
Alexei Svitkine (slow)
lgtm % comments https://codereview.chromium.org/558873002/diff/20001/components/metrics.gypi File components/metrics.gypi (right): https://codereview.chromium.org/558873002/diff/20001/components/metrics.gypi#newcode84 components/metrics.gypi:84: 'metrics/net/wifi_access_point_info_provider.cc', Nit: Put the .cc file ...
6 years, 3 months ago (2014-09-10 14:50:48 UTC) #2
gunsch
https://codereview.chromium.org/558873002/diff/20001/components/metrics.gypi File components/metrics.gypi (right): https://codereview.chromium.org/558873002/diff/20001/components/metrics.gypi#newcode84 components/metrics.gypi:84: 'metrics/net/wifi_access_point_info_provider.cc', On 2014/09/10 14:50:47, Alexei Svitkine wrote: > Nit: ...
6 years, 3 months ago (2014-09-10 16:18:58 UTC) #3
stevenjb
lgtm
6 years, 3 months ago (2014-09-10 17:40:41 UTC) #4
Ben Chan
On 2014/09/10 17:40:41, stevenjb wrote: > lgtm lgtm w.r.t. cros_system_api
6 years, 3 months ago (2014-09-11 18:56:14 UTC) #5
Ben Chan
On 2014/09/10 17:40:41, stevenjb wrote: > lgtm lgtm w.r.t. cros_system_api
6 years, 3 months ago (2014-09-11 18:56:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558873002/40001
6 years, 3 months ago (2014-09-11 19:05:09 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 9506043e88c344b96134dd917698c139bed8befa
6 years, 3 months ago (2014-09-11 21:07:35 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 21:22:54 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/043f36003d1d0a36be39f7eb071eeab5970d6300
Cr-Commit-Position: refs/heads/master@{#294466}

Powered by Google App Engine
This is Rietveld 408576698