Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Unified Diff: runtime/vm/object.h

Issue 558853004: Preserve the contents of Dart strings with unmatched surrogate halfs by avoiding a UTF16 -> UTF8 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: sync and build Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/json_test.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index b9fe6d0e4e34e716bdef4db188d1aa7357505355..d7c24b4926e9b7bcff457311b1ba2a1d68bf71b1 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -5592,16 +5592,6 @@ class String : public Instance {
void ToUTF8(uint8_t* utf8_array, intptr_t array_len) const;
- // Creates a UTF-8, NUL-terminated string in the current zone. The size of the
- // created string in UTF-8 code units (bytes) is answered in 'length'; this
- // can be longer than strlen of the result when the string has internal NULs.
- // For the truncating version, 'max_length' is in UTF-16 code units, and will
- // be rounded down if necessary to prevent splitting a surrogate pair.
- const char* ToCString(intptr_t *length) const;
- const char* ToCStringTruncated(intptr_t max_len,
- bool* did_truncate,
- intptr_t *length) const;
-
// Copies the string characters into the provided external array
// and morphs the string object into an external string object.
// The remaining unused part of the original string object is marked as
« no previous file with comments | « runtime/vm/json_test.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698