runtime/bin/vmservice/observatory/lib/src/service/object.dart - Issue 558853004: Preserve the contents of Dart strings with unmatched surrogate halfs by avoiding a UTF16 -> UTF8

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice/observatory/lib/src/service/object.dart

Issue 558853004: Preserve the contents of Dart strings with unmatched surrogate halfs by avoiding a UTF16 -> UTF8 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: sync and build Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/elements/observatory_element.dart ('k') | runtime/bin/vmservice/observatory/test/string_escaping_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/bin/vmservice/observatory/lib/src/service/object.dart

diff --git a/runtime/bin/vmservice/observatory/lib/src/service/object.dart b/runtime/bin/vmservice/observatory/lib/src/service/object.dart

index 9a1e80cecb30dbc84e76a42b38b51ca2198dd8f0..a2037d336bb6e078fe500a9522861abdf0e77635 100644

--- a/runtime/bin/vmservice/observatory/lib/src/service/object.dart

+++ b/runtime/bin/vmservice/observatory/lib/src/service/object.dart

@@ -1295,6 +1295,8 @@ class ServiceException extends ServiceObject {

name = 'ServiceException $kind';

vmName = name;

}

+ String toString() => 'ServiceException($message)';

}

/// A [ServiceEvent] is an asynchronous event notification from the vm.