Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 558853002: gn: include CR_CLANG_REVISION in defines for clang (Closed)

Created:
6 years, 3 months ago by scottmg
Modified:
6 years, 3 months ago
Reviewers:
brettw, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gn: include CR_CLANG_REVISION in defines for clang This matches gyp behaviour. R=brettw@chromium.org,thakis@chromium.org BUG=335824 Committed: https://crrev.com/b1204ef04bc88d632d7458ae070af34b62eafe33 Cr-Commit-Position: refs/heads/master@{#294098}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -0 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
A tools/clang/scripts/posix-print-revision.py View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
scottmg
6 years, 3 months ago (2014-09-09 23:02:57 UTC) #1
Nico
lgtm
6 years, 3 months ago (2014-09-09 23:10:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/558853002/1
6 years, 3 months ago (2014-09-09 23:25:22 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9828)
6 years, 3 months ago (2014-09-10 00:29:37 UTC) #6
scottmg
Apparently you're the one-and-only-.gn owner Brett.
6 years, 3 months ago (2014-09-10 00:31:02 UTC) #7
brettw
I'm the only build/config owner for now. LGTM
6 years, 3 months ago (2014-09-10 03:28:32 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/558853002/1
6 years, 3 months ago (2014-09-10 03:42:16 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as c8fa6ca2469215ee7b27d1e43d2d1311bd4d268b
6 years, 3 months ago (2014-09-10 03:58:35 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 04:07:34 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1204ef04bc88d632d7458ae070af34b62eafe33
Cr-Commit-Position: refs/heads/master@{#294098}

Powered by Google App Engine
This is Rietveld 408576698