Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 558833002: Cleanup: Use base/files/file_util.h instead of base/file_util.h in apps/ and extensions/ (Closed)

Created:
6 years, 3 months ago by Lei Zhang
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou, brettw
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, jshin+watch_chromium.org, chromium-apps-reviews_chromium.org, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Use base/files/file_util.h instead of base/file_util.h in apps/ and extensions/ Committed: https://crrev.com/9471270bbe0113fce8ccd4a79b22782f21b061a1 Cr-Commit-Position: refs/heads/master@{#294136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M apps/app_shim/app_shim_host_manager_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M apps/app_shim/chrome_main_app_mode_mac.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/app_shim/unix_domain_socket_acceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M apps/launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/storage/leveldb_settings_storage_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/storage/storage_frontend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/computed_hashes.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/content_hash_fetcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/content_hash_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/extension_protocols.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/file_reader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/file_reader_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/image_loader.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/leveldb_value_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/leveldb_value_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/value_store/value_store_frontend_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/verified_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/verified_contents_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_l10n_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_l10n_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_paths.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_resource.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/extension_resource_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/file_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/background_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/manifest_handlers/icons_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/module_system_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/default_shell_browser_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/shell/browser/shell_extension_system.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
6 years, 3 months ago (2014-09-09 21:56:53 UTC) #2
brettw
rs lgtm
6 years, 3 months ago (2014-09-10 00:10:23 UTC) #4
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-10 00:19:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/558833002/1
6 years, 3 months ago (2014-09-10 06:58:45 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 01328426bee38bf9fd681663755000814d7ec164
6 years, 3 months ago (2014-09-10 07:51:24 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 07:55:07 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9471270bbe0113fce8ccd4a79b22782f21b061a1
Cr-Commit-Position: refs/heads/master@{#294136}

Powered by Google App Engine
This is Rietveld 408576698