Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 558823002: Fix crash during shutdown (Closed)

Created:
6 years, 3 months ago by oshima
Modified:
6 years, 3 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, flackr
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix crash during shutdown * keep alive has to be incremented at startup. * exclude more code that depends on ash. * create a screen for shutdown Minor cleanup * remove all containers when ScreenManager is deleted. BUG=397167, 401044 TEST=AthenaShutdownTest.Shutdown Committed: https://crrev.com/13ba9b2b46c0977d30fad57d96da1772c0cf67f1 Cr-Commit-Position: refs/heads/master@{#294083}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -9 lines) Patch
M athena/athena.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M athena/env/athena_env_impl.cc View 1 2 chunks +59 lines, -2 lines 0 comments Download
A athena/env/athena_env_unittest.cc View 1 1 chunk +38 lines, -0 lines 0 comments Download
M athena/screen/screen_manager_impl.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M athena/wm/window_manager_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/athena/chrome_browser_main_extra_parts_athena.cc View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
oshima
6 years, 3 months ago (2014-09-09 22:06:11 UTC) #5
sadrul
https://codereview.chromium.org/558823002/diff/60001/athena/env/athena_env_impl.cc File athena/env/athena_env_impl.cc (right): https://codereview.chromium.org/558823002/diff/60001/athena/env/athena_env_impl.cc#newcode40 athena/env/athena_env_impl.cc:40: class ScreenForShutdown : public gfx::Screen { Any chance this ...
6 years, 3 months ago (2014-09-09 23:27:45 UTC) #6
oshima
https://codereview.chromium.org/558823002/diff/60001/athena/env/athena_env_impl.cc File athena/env/athena_env_impl.cc (right): https://codereview.chromium.org/558823002/diff/60001/athena/env/athena_env_impl.cc#newcode40 athena/env/athena_env_impl.cc:40: class ScreenForShutdown : public gfx::Screen { On 2014/09/09 23:27:44, ...
6 years, 3 months ago (2014-09-09 23:52:46 UTC) #7
sadrul
lgtm
6 years, 3 months ago (2014-09-10 00:01:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/558823002/80001
6 years, 3 months ago (2014-09-10 01:09:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:80001) as 4bb8b50b8100f63af878b9e3b577418a50e933e2
6 years, 3 months ago (2014-09-10 02:50:24 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:58:32 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/13ba9b2b46c0977d30fad57d96da1772c0cf67f1
Cr-Commit-Position: refs/heads/master@{#294083}

Powered by Google App Engine
This is Rietveld 408576698