Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 558813004: Fix certificate length check. (Closed)

Created:
6 years, 3 months ago by jrummell
Modified:
6 years, 3 months ago
Reviewers:
xhwang, ddorwin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix certificate length check. BUG=358271 Committed: https://crrev.com/8d425047be2d1264c544cc3061334575d6a96db3 Cr-Commit-Position: refs/heads/master@{#294200}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M media/cdm/ppapi/cdm_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
jrummell
Here's a minor change to review.
6 years, 3 months ago (2014-09-09 23:52:52 UTC) #2
xhwang
The comment at https://code.google.com/p/chromium/codesearch#chromium/src/media/base/limits.h&l=46 needs to be updated because we also define "min" length there. ...
6 years, 3 months ago (2014-09-10 00:03:24 UTC) #3
ddorwin
I guess we don't have tests for this method yet. :( LGTM
6 years, 3 months ago (2014-09-10 02:23:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrummell@chromium.org/558813004/1
6 years, 3 months ago (2014-09-10 17:35:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 7e16cad63409ee56b2851019258f5a1dd94ed3b6
6 years, 3 months ago (2014-09-10 18:44:19 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 18:49:21 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d425047be2d1264c544cc3061334575d6a96db3
Cr-Commit-Position: refs/heads/master@{#294200}

Powered by Google App Engine
This is Rietveld 408576698