Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 558793002: Adding ArrayBufferView as a constructor type to Response (Closed)

Created:
6 years, 3 months ago by dmurph
Modified:
6 years, 3 months ago
Reviewers:
jsbell, horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@response-work1
Project:
blink
Visibility:
Public.

Description

Adding ArrayBufferView as a constructor type to Response BUG=412027 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181762

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -6 lines) Patch
M LayoutTests/http/tests/serviceworker/resources/response-content-worker.js View 2 chunks +36 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/Response.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/Response.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/Response.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dmurph
Horo, PTAL, this is the ArrayBufferView patch for Response. I'm testing both a plain view ...
6 years, 3 months ago (2014-09-09 21:02:51 UTC) #2
dmurph
6 years, 3 months ago (2014-09-09 21:03:52 UTC) #4
horo
lgtm
6 years, 3 months ago (2014-09-10 04:31:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmurph@chromium.org/558793002/1
6 years, 3 months ago (2014-09-10 18:37:27 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 20:12:41 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 181762

Powered by Google App Engine
This is Rietveld 408576698