Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1948)

Unified Diff: Source/web/WebInputEventConversion.cpp

Issue 558773002: Remove WebTouchEvent.targetTouches (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Cleanup and simplify Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebInputEvent.cpp ('k') | Source/web/tests/WebInputEventConversionTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebInputEventConversion.cpp
diff --git a/Source/web/WebInputEventConversion.cpp b/Source/web/WebInputEventConversion.cpp
index 204429c7f6e95f54467d3efcde20d7732bcd39f3..362b99b254876736cbb944ee74d105b86e6a2732 100644
--- a/Source/web/WebInputEventConversion.cpp
+++ b/Source/web/WebInputEventConversion.cpp
@@ -741,25 +741,44 @@ WebKeyboardEventBuilder::WebKeyboardEventBuilder(const PlatformKeyboardEvent& ev
memcpy(keyIdentifier, event.keyIdentifier().ascii().data(), std::min(static_cast<unsigned>(keyIdentifierLengthCap), event.keyIdentifier().length()));
}
-static void addTouchPoints(const Widget* widget, const AtomicString& touchType, TouchList* touches, WebTouchPoint* touchPoints, unsigned* touchPointsLength, const RenderObject* renderObject)
+static WebTouchPoint toWebTouchPoint(const Touch* touch, const RenderObject* renderObject, WebTouchPoint::State state)
{
- unsigned numberOfTouches = std::min(touches->length(), static_cast<unsigned>(WebTouchEvent::touchesLengthCap));
- for (unsigned i = 0; i < numberOfTouches; ++i) {
+ WebTouchPoint point;
+ point.id = touch->identifier();
+ point.screenPosition = touch->screenLocation();
+ point.position = convertAbsoluteLocationForRenderObjectFloat(touch->absoluteLocation(), *renderObject);
+ point.radiusX = touch->radiusX();
+ point.radiusY = touch->radiusY();
+ point.rotationAngle = touch->webkitRotationAngle();
+ point.force = touch->force();
+ point.state = state;
+ return point;
+}
+
+static bool hasTouchPointWithId(const WebTouchPoint* touchPoints, unsigned touchPointsLength, unsigned id)
+{
+ for (unsigned i = 0; i < touchPointsLength; ++i) {
+ if (touchPoints[i].id == static_cast<int>(id))
+ return true;
+ }
+ return false;
+}
+
+static void addTouchPointsIfNotYetAdded(const Widget* widget, WebTouchPoint::State state, TouchList* touches, WebTouchPoint* touchPoints, unsigned* touchPointsLength, const RenderObject* renderObject)
+{
+ unsigned initialTouchPointsLength = *touchPointsLength;
+ for (unsigned i = 0; i < touches->length(); ++i) {
+ const unsigned pointIndex = *touchPointsLength;
+ if (pointIndex >= static_cast<unsigned>(WebTouchEvent::touchesLengthCap))
+ return;
+
const Touch* touch = touches->item(i);
+ if (hasTouchPointWithId(touchPoints, initialTouchPointsLength, touch->identifier()))
+ continue;
- WebTouchPoint point;
- point.id = touch->identifier();
- point.screenPosition = touch->screenLocation();
- point.position = convertAbsoluteLocationForRenderObjectFloat(touch->absoluteLocation(), *renderObject);
- point.radiusX = touch->radiusX();
- point.radiusY = touch->radiusY();
- point.rotationAngle = touch->webkitRotationAngle();
- point.force = touch->force();
- point.state = toWebTouchPointState(touchType);
-
- touchPoints[i] = point;
+ touchPoints[pointIndex] = toWebTouchPoint(touch, renderObject, state);
+ ++(*touchPointsLength);
}
- *touchPointsLength = numberOfTouches;
}
WebTouchEventBuilder::WebTouchEventBuilder(const Widget* widget, const RenderObject* renderObject, const TouchEvent& event)
@@ -782,9 +801,8 @@ WebTouchEventBuilder::WebTouchEventBuilder(const Widget* widget, const RenderObj
timeStampSeconds = event.timeStamp() / millisPerSecond;
cancelable = event.cancelable();
- addTouchPoints(widget, event.type(), event.touches(), touches, &touchesLength, renderObject);
- addTouchPoints(widget, event.type(), event.changedTouches(), changedTouches, &changedTouchesLength, renderObject);
- addTouchPoints(widget, event.type(), event.targetTouches(), targetTouches, &targetTouchesLength, renderObject);
+ addTouchPointsIfNotYetAdded(widget, toWebTouchPointState(event.type()), event.changedTouches(), touches, &touchesLength, renderObject);
+ addTouchPointsIfNotYetAdded(widget, WebTouchPoint::StateStationary, event.touches(), touches, &touchesLength, renderObject);
}
WebGestureEventBuilder::WebGestureEventBuilder(const Widget* widget, const RenderObject* renderObject, const GestureEvent& event)
« no previous file with comments | « Source/web/WebInputEvent.cpp ('k') | Source/web/tests/WebInputEventConversionTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698