Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 558753002: Correctly mark all mouse events derived from touch with FromTouch (Closed)

Created:
6 years, 3 months ago by Rick Byers
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, eae+blinkwatch, Ignacio Solla
Project:
blink
Visibility:
Public.

Description

Correctly mark all mouse events derived from touch with FromTouch Bug 401177 added more explicit tracking of the source of synthetic mouse events. This CL updates the remianing places that generate mouse event from touch input to explicitly mark them as so. To do this I've removed an ASSERT I added that attempted to lock-in hit-test reduction improvements. We have a dedicated test for this (hit-test-counts.html) and so the ASSERT wasn't adding much. It's not worth the effort at this point to refactor the touch drag and drop code (a little used feature) to remove a couple of hit tests (but I've left the comments in place saying that ideally we'd do so in the future). BUG=408660 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181780

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M Source/core/page/EventHandler.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M Source/web/PopupContainer.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Rick Byers
Alex, PTAL at this tiny patch. It should not have any behavioral impact, so this ...
6 years, 3 months ago (2014-09-10 14:35:39 UTC) #2
aelias_OOO_until_Jul13
lgtm, but I don't have Source/core/ OWNERS.
6 years, 3 months ago (2014-09-10 16:06:49 UTC) #3
Rick Byers
On 2014/09/10 16:06:49, aelias wrote: > lgtm, but I don't have Source/core/ OWNERS. No worries, ...
6 years, 3 months ago (2014-09-11 01:27:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558753002/1
6 years, 3 months ago (2014-09-11 01:28:47 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 01:32:37 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181780

Powered by Google App Engine
This is Rietveld 408576698