Integration test for bypassing the proxy for a single request

Integration test for bypassing the proxy for a single request

This test verifies that the "Chrome-Proxy: block-once" directive for
bypassing the data reduction proxy for just the current request works as
expected.

BUG=404053
Committed: https://crrev.com/b752e88be5de806c37201d19f116262e38734ac9
Cr-Commit-Position: refs/heads/master@{#295197}

[sclittle, 2014-09-15 17:48:35]

sclittle@chromium.org changed reviewers:
+ bengr@chromium.org, bolian@chromium.org

[sclittle, 2014-09-15 17:49:43]

bengr, bolian: all

Thanks in advance

[bengr, 2014-09-16 01:49:02]

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py (right):

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py:82: tag =
'block_single'
Why not call this block_once?

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py:83: test =
measurements.ChromeProxyBlockSingle
BlockOnce, here and everywhere.

[bolian, 2014-09-16 17:04:07]

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:254: if
eligible_response_count <= 1:
Question. Why there will be more than one?  Do you see one from DRP to instruct
bypass another from direct loading? I remember in the past, the first response
was not exposed at this level.

[sclittle, 2014-09-16 19:06:53]

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py (right):

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py:82: tag =
'block_single'
On 2014/09/16 01:49:02, bengr1 wrote:
> Why not call this block_once?

Done.

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_benchmark.py:83: test =
measurements.ChromeProxyBlockSingle
On 2014/09/16 01:49:02, bengr1 wrote:
> BlockOnce, here and everywhere.

Done.

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:254: if
eligible_response_count <= 1:
On 2014/09/16 17:04:06, bolian wrote:
> Question. Why there will be more than one?  Do you see one from DRP to
instruct
> bypass another from direct loading? I remember in the past, the first response
> was not exposed at this level.

There would be more than one because http://check.googlezip.net/blocksingle
loads the google 404 not found page, which has a google logo image on it. The
idea was to test that the response for http://check.googlezip.net/blocksingle
bypassed the DRP, but the image that was requested immediately after that
response was received did not bypass the DRP.

This check that more that one response was received may not be necessary, since
the test already checks that the bad proxy list is empty which implies that only
one response would bypass the DRP. The eligible_response_count check also makes
the test dependent on the 404 not found page having at least one subresource on
it, which might be bad. I can remove this eligible_response_count check if you
think it's unnecessary.

[bolian, 2014-09-16 20:56:00]

lgtm

FYI, if/when you think the test is ready to run in the trybot, please add a new
command in private repository clank/build/chrome_proxy_tests.json

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
File tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py (right):

https://codereview.chromium.org/558743003/diff/1/tools/chrome_proxy/integrati...
tools/chrome_proxy/integration_tests/chrome_proxy_metrics.py:254: if
eligible_response_count <= 1:
No, don't remove that. :) I wasn't aware that the page contains another
resource. Thanks for explaining this.

[sclittle, 2014-09-16 21:09:18]

The CQ bit was checked by sclittle@chromium.org

[commit-bot: I haz the power, 2014-09-16 21:09:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/558743003/20001

[commit-bot: I haz the power, 2014-09-16 21:09:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 21:09:55]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[bengr, 2014-09-16 21:55:38]

lgtm, with nit.

https://codereview.chromium.org/558743003/diff/20001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py
(right):

https://codereview.chromium.org/558743003/diff/20001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py:23:
'http://check.googlezip.net/blocksingle',
What is this URL?

[sclittle, 2014-09-16 22:05:55]

https://codereview.chromium.org/558743003/diff/20001/tools/chrome_proxy/integ...
File tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py
(right):

https://codereview.chromium.org/558743003/diff/20001/tools/chrome_proxy/integ...
tools/chrome_proxy/integration_tests/chrome_proxy_pagesets/block_once.py:23:
'http://check.googlezip.net/blocksingle',
On 2014/09/16 21:55:37, bengr1 wrote:
> What is this URL?

Other test page sets use similar URLs, such as http://aws1.mdw.la/bypass/

[sclittle, 2014-09-16 22:06:10]

The CQ bit was checked by sclittle@chromium.org

[commit-bot: I haz the power, 2014-09-16 22:07:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/558743003/20001

[commit-bot: I haz the power, 2014-09-17 00:54:30]

Committed patchset #2 (id:20001) as 2facfa15f5e28f3531d84405d3e9fccf61f9ba93

[commit-bot: I haz the power, 2014-09-17 00:55:07]

Patchset 2 (id:??) landed as
https://crrev.com/b752e88be5de806c37201d19f116262e38734ac9
Cr-Commit-Position: refs/heads/master@{#295197}