Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 558743002: Revert of Revert of HTMLConstructionSite: avoid n^2 running time for large scripts. (Closed)

Created:
6 years, 3 months ago by jianli
Modified:
6 years, 3 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org, abarth-chromium, kouhei (in TOK)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of HTMLConstructionSite: avoid n^2 running time for large scripts. (patchset #1 id:1 of https://codereview.chromium.org/555223002/) Reason for revert: Not a culprit. Reverted to bring back the original patch. Original issue's description: > Revert of HTMLConstructionSite: avoid n^2 running time for large scripts. (patchset #5 id:80001 of https://codereview.chromium.org/494993002/) > > Reason for revert: > Speculative revert. > > It may break the following blink sheriff bot: > http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/21403 > > > > Original issue's description: > > HTMLConstructionSite: avoid n^2 running time for large scripts. > > > > Every time background parser sends chunk, tree is flushed. > > > > If page contains very large script, then script node content is updated > > many times. Every update is causes string concatenation. > > > > Solution: do not flush pending text until it is mandatory. > > > > Test: https://codereview.chromium.org/500363002 > > Test depends on: https://codereview.chromium.org/544453004/ > > > > BUG=410790 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181635 > > TBR=eseidel@chromium.org,kouhei@chromium.org,eustas@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=410790 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181664 TBR=eseidel@chromium.org,kouhei@chromium.org,eustas@chromium.org NOTREECHECKS=true NOTRY=true BUG=410790 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181668

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M Source/core/html/parser/HTMLConstructionSite.h View 2 chunks +12 lines, -4 lines 0 comments Download
M Source/core/html/parser/HTMLConstructionSite.cpp View 5 chunks +9 lines, -5 lines 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 2 chunks +4 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.h View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jianli
Created Revert of Revert of HTMLConstructionSite: avoid n^2 running time for large scripts.
6 years, 3 months ago (2014-09-09 19:57:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jianli@chromium.org/558743002/1
6 years, 3 months ago (2014-09-09 19:58:04 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 19:59:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181668

Powered by Google App Engine
This is Rietveld 408576698