Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 558723003: history: make focus outline look good on all platforms. (Closed)

Created:
6 years, 3 months ago by Dan Beam
Modified:
6 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

history: make focus outline look good on all platforms. R=estade@chromium.org BUG=411771 Committed: https://crrev.com/026df712419ca88f5179fd3955528b19e5f59dc5 Cr-Commit-Position: refs/heads/master@{#294219}

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment for estade@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/resources/history/history.css View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Dan Beam
6 years, 3 months ago (2014-09-09 23:33:45 UTC) #1
Evan Stade
lgtm https://codereview.chromium.org/558723003/diff/1/chrome/browser/resources/history/history.css File chrome/browser/resources/history/history.css (right): https://codereview.chromium.org/558723003/diff/1/chrome/browser/resources/history/history.css#newcode513 chrome/browser/resources/history/history.css:513: <if expr="is_mac"> nit: add a comment abuot why ...
6 years, 3 months ago (2014-09-10 18:38:35 UTC) #2
Dan Beam
https://codereview.chromium.org/558723003/diff/1/chrome/browser/resources/history/history.css File chrome/browser/resources/history/history.css (right): https://codereview.chromium.org/558723003/diff/1/chrome/browser/resources/history/history.css#newcode513 chrome/browser/resources/history/history.css:513: <if expr="is_mac"> On 2014/09/10 18:38:35, Evan Stade wrote: > ...
6 years, 3 months ago (2014-09-10 19:02:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/558723003/20001
6 years, 3 months ago (2014-09-10 19:05:05 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4d5e66973011c039bffed92a5e00bdbc82dc61cb
6 years, 3 months ago (2014-09-10 20:39:44 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 20:44:46 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/026df712419ca88f5179fd3955528b19e5f59dc5
Cr-Commit-Position: refs/heads/master@{#294219}

Powered by Google App Engine
This is Rietveld 408576698