Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 558713002: Make PRODUCT_STRING_PATH accessible via chrome_constants.h (Closed)

Created:
6 years, 3 months ago by erikwright (departed)
Modified:
6 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@clean_exit_beacon
Project:
chromium
Visibility:
Public.

Description

Make PRODUCT_STRING_PATH accessible via chrome_constants.h BUG=412398 Committed: https://crrev.com/765ca9d12cf7a2b21fda47ce76efef16b35986df Cr-Commit-Position: refs/heads/master@{#294470}

Patch Set 1 #

Patch Set 2 : Remove unrelated code churn. #

Patch Set 3 : Rebase. #

Patch Set 4 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -20 lines) Patch
M chrome/common/chrome_constants.h View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/common/chrome_constants.cc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/common/terminate_on_heap_corruption_experiment_win.cc View 2 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
erikwright (departed)
sky: PTAL. I am de-duping this because I plan to re-use the PRODUCT_STRING_PATH macro in ...
6 years, 3 months ago (2014-09-09 18:27:27 UTC) #2
sky
LGTM
6 years, 3 months ago (2014-09-09 19:18:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/558713002/20001
6 years, 3 months ago (2014-09-09 19:34:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/64580) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/53579) win_gpu ...
6 years, 3 months ago (2014-09-09 20:32:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/558713002/60001
6 years, 3 months ago (2014-09-11 18:39:56 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 4e04a2caabcb4d126950aca7b0ca9d1f44ec2e5f
6 years, 3 months ago (2014-09-11 21:37:30 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 21:48:13 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/765ca9d12cf7a2b21fda47ce76efef16b35986df
Cr-Commit-Position: refs/heads/master@{#294470}

Powered by Google App Engine
This is Rietveld 408576698