Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart

Issue 558703005: Do not navigate to vm-connect page upon disconnect (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/app/application.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart
diff --git a/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart b/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart
index 04b6d84bbf7f69a13984f2e8497871bd914440dc..0d7705bdda54ebc9682efce359c32bbfb3d655f1 100644
--- a/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart
+++ b/runtime/bin/vmservice/observatory/lib/src/app/location_manager.dart
@@ -33,6 +33,10 @@ abstract class LocationManager extends Observable {
/// Go to a specific url.
void go(String url) {
if (_app.vm == null) {
+ if (!window.confirm('Connection with VM has been lost. '
+ 'Proceeding will lose current page.')) {
+ return;
+ }
url = makeLink('/vm-connect/');
turnidge 2014/09/15 16:24:48 Consider adding a notification.
Cutch 2014/09/15 18:11:20 Done. I notify the user immediately on disconnect.
}
_pushUrl(url);
« no previous file with comments | « runtime/bin/vmservice/observatory/lib/src/app/application.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698