chrome/browser/metrics/chrome_metrics_service_client.cc - Issue 558683002: Extract the handling of the clean exit beacon from MetricsService. The extracted implementation sup…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/chrome_metrics_service_client.cc

Issue 558683002: Extract the handling of the clean exit beacon from MetricsService. The extracted implementation sup… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Review feedback. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/metrics/chrome_metrics_service_client.cc

diff --git a/chrome/browser/metrics/chrome_metrics_service_client.cc b/chrome/browser/metrics/chrome_metrics_service_client.cc

index 4db6bcc74eb2088f9ff1e126a34e1177b2381274..929c5b6a4c453e785fa461d40d3f93c108096a99 100644

--- a/chrome/browser/metrics/chrome_metrics_service_client.cc

+++ b/chrome/browser/metrics/chrome_metrics_service_client.cc

@@ -272,6 +272,12 @@ ChromeMetricsServiceClient::CreateUploader(

on_upload_complete));

}

+#if defined(OS_WIN)

+base::string16 ChromeMetricsServiceClient::GetRegistryBackupKey() {

+ return L"Software\\" PRODUCT_STRING_PATH L"\\StabilityMetrics";

Alexei Svitkine (slow) 2014/09/11 15:23:28 Hmm, where is PRODUCT_STRING_PATH defined? In cs.c

erikwright (departed) 2014/09/11 15:39:14 See https://codereview.chromium.org/558713002/ whi

+#endif

void ChromeMetricsServiceClient::LogPluginLoadingError(

const base::FilePath& plugin_path) {

#if defined(ENABLE_PLUGINS)

« no previous file with comments | « chrome/browser/metrics/chrome_metrics_service_client.h ('k') | components/metrics.gypi » ('j') | components/metrics/clean_exit_beacon.h » ('J')