Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Unified Diff: Source/core/inspector/PromiseTracker.h

Issue 558673003: Oilpan: move PromiseTracker to the heap (fix build after r181646.) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Non-oilpan compile fixes Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/inspector/PromiseTracker.h
diff --git a/Source/core/inspector/PromiseTracker.h b/Source/core/inspector/PromiseTracker.h
index fc3ec0475385cf5f6a1f7107d03eb4d7668546ef..97bc2d479a0a85cfacc04bdd7d719bc55ebb1658 100644
--- a/Source/core/inspector/PromiseTracker.h
+++ b/Source/core/inspector/PromiseTracker.h
@@ -6,6 +6,7 @@
#define PromiseTracker_h
#include "core/InspectorTypeBuilder.h"
+#include "platform/heap/Handle.h"
#include "wtf/HashMap.h"
#include "wtf/Noncopyable.h"
#include "wtf/RefPtr.h"
@@ -16,8 +17,9 @@ namespace blink {
class ScriptState;
-class PromiseTracker {
+class PromiseTracker FINAL {
WTF_MAKE_NONCOPYABLE(PromiseTracker);
+ DISALLOW_ALLOCATION();
public:
PromiseTracker();
~PromiseTracker();
@@ -33,12 +35,14 @@ public:
class PromiseData;
- typedef Vector<RefPtr<PromiseData> > PromiseDataVector;
- typedef HashMap<int, PromiseDataVector> PromiseDataMap;
+ typedef WillBeHeapVector<RefPtrWillBeMember<PromiseData> > PromiseDataVector;
+ typedef WillBeHeapHashMap<int, PromiseDataVector> PromiseDataMap;
+
+ void trace(Visitor*);
private:
int circularSequentialId();
- PassRefPtr<PromiseData> createPromiseDataIfNeeded(v8::Isolate*, v8::Handle<v8::Object> promise);
+ PassRefPtrWillBeRawPtr<PromiseData> createPromiseDataIfNeeded(v8::Isolate*, v8::Handle<v8::Object> promise);
bool m_isEnabled;
int m_circularSequentialId;

Powered by Google App Engine
This is Rietveld 408576698