Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 558663003: Move navigation handling code from TranslateClient to TranslateDriver (Closed)

Created:
6 years, 3 months ago by droger
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, erikwright+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move navigation handling code from TranslateClient to TranslateDriver This CL moves code from chrome/ (ChromeTranslateClient) to the translate component (ContentTranslateDriver). BUG=331509 Committed: https://crrev.com/5cd641278bef09e5c77424b7eb69f8ff1ca628bf Cr-Commit-Position: refs/heads/master@{#294157}

Patch Set 1 : #

Patch Set 2 : add missing initialization #

Total comments: 2

Patch Set 3 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -119 lines) Patch
M chrome/browser/translate/chrome_translate_client.h View 4 chunks +0 lines, -19 lines 0 comments Download
M chrome/browser/translate/chrome_translate_client.cc View 4 chunks +2 lines, -95 lines 0 comments Download
M chrome/browser/translate/translate_manager_render_view_host_unittest.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M components/translate/content/browser/content_translate_driver.h View 1 2 4 chunks +33 lines, -1 line 0 comments Download
M components/translate/content/browser/content_translate_driver.cc View 1 2 chunks +106 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
droger
6 years, 3 months ago (2014-09-10 07:52:58 UTC) #3
Andrew Hayden (chromium.org)
LGTM! https://codereview.chromium.org/558663003/diff/30001/components/translate/content/browser/content_translate_driver.h File components/translate/content/browser/content_translate_driver.h (right): https://codereview.chromium.org/558663003/diff/30001/components/translate/content/browser/content_translate_driver.h#newcode51 components/translate/content/browser/content_translate_driver.h:51: void set_translate_manager(TranslateManager* manager) { For consistency with other ...
6 years, 3 months ago (2014-09-10 09:19:52 UTC) #4
droger
Thanks for the review. https://codereview.chromium.org/558663003/diff/30001/components/translate/content/browser/content_translate_driver.h File components/translate/content/browser/content_translate_driver.h (right): https://codereview.chromium.org/558663003/diff/30001/components/translate/content/browser/content_translate_driver.h#newcode51 components/translate/content/browser/content_translate_driver.h:51: void set_translate_manager(TranslateManager* manager) { On ...
6 years, 3 months ago (2014-09-10 09:58:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/droger@chromium.org/558663003/50001
6 years, 3 months ago (2014-09-10 10:00:06 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:50001) as 72d65d523faf64bf9cf0bcf9cb120d38a013330c
6 years, 3 months ago (2014-09-10 11:12:21 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 11:14:55 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/5cd641278bef09e5c77424b7eb69f8ff1ca628bf
Cr-Commit-Position: refs/heads/master@{#294157}

Powered by Google App Engine
This is Rietveld 408576698